Added two differents errors events. 'error' is for specific AWS clien… #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t error and 'processing_error' is for app message processing errors
| @@ -27,6 +27,10 @@ app.on('error', function (err) { | |||
| console.log(err.message); | |||
| }); | |||
|
|
|||
| app.on('processing_error', function (err) { | |||
There was a problem hiding this comment.
Just one more request...
Can we leave this as error? It's in the example because if you don't listen to error events on an EventEmitter it'll throw the exception and crash your app. I'm ok with leaving the new event out of the main example.
robinjmurphy
added a commit
that referenced
this pull request
Dec 3, 2015
Added two differents errors events. 'error' is for specific AWS clien…
|
Can you please release a new version?. |
|
Published as 3.0.0 to NPM and here https://github.com/bbc/sqs-consumer/releases/tag/v3.0.0 |
|
Thanks |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t error and 'processing_error' is for app message processing errors