fix: removing bind and refactoring consumer

[mogu4iy]

Resolves #NUMBER

Description:

There is an inheritance issue, that it's not possible to extend Consumer class. It happens because you autoBind all propertyNames from constructor.prototype, so while extending these properties are not accessible anymore in this way.

Type of change:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:

There are cases when we what to extend Consumer class, to pass pre defined options for example.
I have created minimal reproducible exaple.

Code changes:

• Add missing type declarations
• Remove autoBind usage to let extend this class
• Update passing in-class methods to intervals using arrow functions to solve context passing issue

---

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[mogu4iy]

@nicholasgriffintn I hope you can check this as well ;)

[nicholasgriffintn]

Hey, thanks for the PR.

I'm not too sure the reasoning behind the bind, and if we need it or not honestly, it's before my time.

I'll have to have a look through this when I have a spare hour or two, bare with :).

[mogu4iy]

Hey, thanks for the PR.

I'm not too sure the reasoning behind the bind, and if we need it or not honestly, it's before my time.

I'll have to have a look through this when I have a spare hour or two, bare with :).

It was used to avoid passing class methods to intervals or promise then calls using arrow functions.

[nicholasgriffintn]

Yeh it was part of the original commit years ago, so potentially just old Node/JS thoughts. I'll have a proper look through tomorrow.

[codeclimate]

Code Climate has analyzed commit 3a292f2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.3% (0.0% change).

View more on Code Climate.

[mogu4iy]

@nicholasgriffintn any updates?

[mogu4iy]

I am also interested in estimates, when you are going to release 10.0.0

[nicholasgriffintn]

Sorry for the delay, got stuck with the day job. This will be in v10.0.0-canary.3 and eventually v10.

We don't have a date for version 10 yet, ultimately it will be whenever we feel confident to release it without risk of issues, we've not yet done the testing for that, in the meantime, the canary version can be installed.