Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is ts-node-register production dependency intended? #46

Closed
koresar opened this issue May 15, 2020 · 1 comment
Closed

Is ts-node-register production dependency intended? #46

koresar opened this issue May 15, 2020 · 1 comment

Comments

@koresar
Copy link
Contributor

koresar commented May 15, 2020

As per contribution guide rising this important question before submitting a 1-line PR.

I found that ts-node-register is a production dependency of the module. ts-node-register has few unnecessary subdependencies.

I would assume including this was an incident. The ts-node-register is not used anywhere.

Should I submit a PR to remove this line from package.json?
@nspragg
Copy link
Contributor

nspragg commented May 15, 2020

Thanks, @koresar

ts-node-register should not be in dependencies. This has been removed and a patch released.

@nspragg nspragg closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koresar @nspragg