chore: parse over dependencies and update #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannymeloy
requested changes
Nov 9, 2023
There was a problem hiding this comment.
Looks good. Glad to have a commit to base the removal of sass-lint on in other repos.
Few small comments below. Would be good to get rid of any lint exceptions, unless there is a specific reason why they are like that of course. And I wondered about defining a more specific node version
craigjohnwright
force-pushed
the
maintenance
branch
from
2d50648
to
1d11a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse over all dependencies and update where possible.
Highlights: Updates to node 20; replaces long-dead sass-lint; updates shaka-player.