[READY] Milestone 3.0 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstract CasperJS/PhantomJS files away
[In Progress] Efficient mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of:
Changes to API:
snap_fileproperty is NO LONGER NEEDED - it is abstracted away inside the Wraith gem itself. You can still specify your ownsnap_fileif you wish (it will take precedence), but the default should now be to remove the property altogether and allow Wraith to select its own internal snap file.resize_or_reloadproperty, with values either 'resize' or 'reload'. Up to version 2.8.1, Wraith uses 'reload' behaviour, i.e. it reloads the browser for every screen width screenshot. For the time being, that is still the default. But those who wish to run much faster Wraith tests can switch to the new 'resize' mode, which resizes the current browser instance to take screenshots, rather than firing up the browser again and again.