Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet: Add release notes to packages #154

Closed
wants to merge 2 commits into from

Conversation

sungaila
Copy link
Contributor

The GitHub releases have these nice auto-generated release notes containing the chromium branch name and commit messages. It would be great to have these for the NuGet packages, too.

NuGet release notes are plain text and don't support markdown (NuGet/NuGetGallery#8889) so the format and URLs had to be stripped.

I haven't tested this change myself so it would be a good idea to double check if this bash script/workflow yaml looks correct.

@bblanchon
Copy link
Owner

I don't think we'll manage to pass a multiline string to the command line.
We should patch the nuspec file instead.

@bblanchon
Copy link
Owner

On nuget.org, I could find very few packages that define the release notes, and the ones I found only included a link to an external page.
I suggest we do the same with a link to the GitHub release.

@sungaila
Copy link
Contributor Author

I suggest we do the same with a link to the GitHub release.

Then how about doing just that. :-) This one has no fallback if the chromium branch was unset. Maybe something like https://github.com/bblanchon/pdfium-binaries/releases/latest?

@bblanchon bblanchon closed this in ad10506 Jan 26, 2024
@sungaila sungaila deleted the nuget-releasenotes branch January 26, 2024 09:13
bblanchon added a commit that referenced this pull request Jan 26, 2024
@bblanchon
Copy link
Owner

image

@sungaila
Copy link
Contributor Author

@jerbob92 Lookin' great! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants