Typed filter functions for queries with boolean/number/string results #43
Conversation
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Typo Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Remove unneeded include Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
juanjux
force-pushed
the
feature/xpath_functions
branch
from
e0b4c17
to
7115aba
Compare
tools/bindings.go
Outdated
| @@ -79,6 +79,15 @@ func ptrToNode(ptr C.uintptr_t) *uast.Node { | |||
| return (*uast.Node)(unsafe.Pointer(uintptr(ptr))) | |||
| } | |||
|
|
|||
| func initFilter(node *uast.Node, xpath string) (*C.char, int, C.uintptr_t) { | |||
There was a problem hiding this comment.
it will be great to have a comment that this function acquires findMutex and caller should unlock it
There was a problem hiding this comment.
On the second thought, it's better to return some closer func() that caller should defer.
It can include SetGCPercent as well.
tools/bindings.go
Outdated
| if !C.Filter(ptr, cquery) { | ||
| error := C.Error() | ||
| return nil, fmt.Errorf("UastFilter() failed: %s", C.GoString(error)) | ||
| errorf := fmt.Errorf("UastFilter() failed: %s", C.GoString(error)) | ||
| C.free(unsafe.Pointer(error)) |
There was a problem hiding this comment.
these 3 lines can be moved to a separate function, so no caller will be able to leak it
tools/bindings.go
Outdated
| func initFilter(node *uast.Node, xpath string) (*C.char, int, C.uintptr_t) { | ||
| findMutex.Lock() | ||
| cquery := pool.getCstring(xpath) | ||
| gcpercent := debug.SetGCPercent(-1) |
There was a problem hiding this comment.
Cargo cult... it was before for the existing functions, I guess the previous programmer found it was needed to avoid problems with C variables, I'll try to remove it and do some intensive testing.
There was a problem hiding this comment.
I've done some testing with a loop and millions of calls and I didn't find any problem, so I've removed the calls to disable/reenable the GC. We should remember this in case there are odd problems in the future that could be causes by this, but I didn't see any need to disable the GC on cgo documentation.
tools/bindings.h
Outdated
| if (!c_ok) { | ||
| *ok = 0; | ||
| } | ||
| *ok = 1; |
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
|
@dennwc changes done, please check |
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Remove unneded import Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
juanjux
force-pushed
the
feature/xpath_functions
branch
from
8360e9f
to
9ba708f
Compare
FilterBool,FilterNumber,FilterString.C.free()s after returns o_O and thus memory leaks.