This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
new fixtures for semantic UAST #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denys Smirnov <denys@sourced.tech>
Signed-off-by: Denys Smirnov <denys@sourced.tech>
juanjux
reviewed
Mar 2, 2018
fixtures/u2_class_inherits.go
Outdated
| package fixtures | ||
|
|
||
| type Foo struct { | ||
| Bar |
There was a problem hiding this comment.
Having Bar defined above would make the test more complete.
juanjux
reviewed
Mar 2, 2018
fixtures/u2_type_interface_extend.go
Outdated
| package fixtures | ||
|
|
||
| type Foo interface { | ||
| Bar |
juanjux
reviewed
Mar 2, 2018
| @@ -0,0 +1,7 @@ | |||
| package fixtures | |||
|
|
|||
| type Foo int | |||
There was a problem hiding this comment.
There is some inconsistency because in some test filenames the types are called u2_class, but here are called u2_type, is there a rationale for this?
There was a problem hiding this comment.
I consider "classes" as something that can have fields, while "types" can only have methods attached. Probably it's wrong.
juanjux
approved these changes
Mar 2, 2018
Signed-off-by: Denys Smirnov <denys@sourced.tech>
|
Not wrong, just an opinable matter, the important thing would be to use the same criteria for all languages with structural subtyping. |
|
Closing this one, it's superseded by #17 branched from this one. |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denys Smirnov denys@sourced.tech