This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
Support Unicode character offsets #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2019 17:42
Signed-off-by: Denys Smirnov <denys@sourced.tech>
Signed-off-by: Denys Smirnov <denys@sourced.tech>
dennwc
changed the title
Signed-off-by: Denys Smirnov <denys@sourced.tech>
juanjux
approved these changes
Jan 14, 2019
|
Nice! |
creachadair
reviewed
Jan 14, 2019
Signed-off-by: Denys Smirnov <denys@sourced.tech>
|
@creachadair PTAL |
creachadair
approved these changes
Jan 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SDK only supports positional offset in bytes or line-column pair, where a column is given in bytes.
PR implements a new
Positionerthat converts Unicode character offsets to a byte offset and a line-column pair (in bytes as well).Also, refactor long name for position functions to something shorter and place a deprecation note on the old ones.
This is change will allow to solve issues like bblfsh/javascript-driver#25.