Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a failing spec demonstrating a bug in the em-http-request adapter. #185

Merged
merged 3 commits into from
Aug 26, 2012

Commits on May 25, 2012

  1. Add a failing spec demonstrating a bug in the em-http-request adapter.

    When a request is made to a URL that returns a 3xx response and the
    :redirects option is set, the globally_stub_request/after_request
    hooks are not paired properly.  Both hooks should receive the original
    request and the redirect-following request.
    
    This spec should probably be re-written to use the local webmock
    server, but I couldn't figure out how to get it to conditionally
    send a redirect response since it writes directly to the socket
    and doesn't (as far as I can tell) have the request info available
    in that scope...so there's not easy way to have it send a different
    response for different requests :(.
    
    See myronmarston/vcr#171 for the original VCR issue that caused
    me to investigate this bug.
    myronmarston committed May 25, 2012
    Configuration menu
    Copy the full SHA
    a42d463 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2012

  1. Configuration menu
    Copy the full SHA
    dc0e226 View commit details
    Browse the repository at this point in the history
  2. Fixed em-http-adapter bug. When a request is made to a URL that retur…

    …ns a 3xx response and the :redirects option is set, the globally_stub_request/after_request
    
    hooks are now fired for the original request and the redirect-following request.
    bblimke committed Aug 26, 2012
    Configuration menu
    Copy the full SHA
    806818f View commit details
    Browse the repository at this point in the history