Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net http response refactoring #39

Conversation

myronmarston
Copy link
Collaborator

I refactored my implementation of the Net::HTTPResponse extension module to be far simpler, and thought you might want what I wound up with :).

@myronmarston
Copy link
Collaborator Author

Actually, hold off on this for now. I think I discovered some edge cases that neither the original code nor this refactoring handle properly. I'll let you know once I've figured it out.

@myronmarston
Copy link
Collaborator Author

OK, I made a minor change and pushed it here:

http://github.com/myronmarston/webmock/commit/f3cf8a2a24838e50eba4f0da9acf3b0eb0904f1e

Besides the simplification, this addresses a minor issue with making a HEAD request and reading the response with a block and #read_body.

@bblimke
Copy link
Owner

bblimke commented Sep 12, 2010

Thanks Myron. I like it :) Merged.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants