Improved cookies support for WebMockHttpClient #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2014 11:48
|
Can't reproduce the failing test. Any help on this please? |
|
@bblimke ? |
|
Looks good. Cheers! :) Probably randomly failing test |
bblimke
added a commit
that referenced
this pull request
Jun 1, 2014
…support Improved cookies support for WebMockHttpClient
|
It looks like it's failing on Jruby. Have you run specs using jruby? |
|
Nope, sorry, never used JRuby :) I'll do it now and try to fix it. |
|
Looks like a problem between JRuby and EventMachine. I see you not running specs if JRuby & EventMachine (unless RUBY_PLATFORM =~ /java/). Why is that? Do you want me to do the same? |
|
Yes, you should move your |
|
Ok, done. Hopefully now will work. Pull request here: #394 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebMockHttpClient now supports setting multiple cookies at once by using an array (As em-http-request does).
I also added an utility method to easily access those response cookies to be able to test them.
Unit tests included.