Skip to content

Improved cookies support for WebMockHttpClient #392

Merged
merged 2 commits into from Jun 1, 2014

2 participants

@calonso
calonso commented May 23, 2014

WebMockHttpClient now supports setting multiple cookies at once by using an array (As em-http-request does).

I also added an utility method to easily access those response cookies to be able to test them.

Unit tests included.

@calonso
calonso commented May 27, 2014

Can't reproduce the failing test. Any help on this please?

@bblimke
Owner
bblimke commented Jun 1, 2014

Looks good. Cheers! :)

Probably randomly failing test

@bblimke bblimke merged commit 03914e2 into bblimke:master Jun 1, 2014

1 check failed

Details continuous-integration/travis-ci The Travis CI build failed
@bblimke
Owner
bblimke commented Jun 1, 2014

It looks like it's failing on Jruby. Have you run specs using jruby?

@calonso
calonso commented Jun 1, 2014

Nope, sorry, never used JRuby :) I'll do it now and try to fix it.

@calonso
calonso commented Jun 1, 2014

Looks like a problem between JRuby and EventMachine. I see you not running specs if JRuby & EventMachine (unless RUBY_PLATFORM =~ /java/). Why is that? Do you want me to do the same?

@bblimke
Owner
bblimke commented Jun 1, 2014

Yes, you should move your spec/unit/http_lib_adapters/webmock_http_client_spec.rb examples as part of https://github.com/bblimke/webmock/blob/master/spec/acceptance/em_http_request/em_http_request_spec.rb

@calonso
calonso commented Jun 1, 2014

Ok, done. Hopefully now will work. Pull request here: #394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.