Threadsafe manticore client #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManticoreAdapter was not thread-safe. Multiple threads would access the same Client instance, which stored @uri, @method, and @options. Multiple concurrent requests would cause data inconsistencies and map responses to the incorrect request. Fixing the thread-safety exposed several failing tests in the Manticore specs. The gist of this is, Webmock allows you to stub with headers that have Array values. e.g. `:headers => { 'Accept' => ['image/jpg', 'image/png'] } However, you cannot pass an Array as a header value to the Manticore library. It is the user's responsibility to concatenate this to a comma-separated string. In order to match the configured stub, you have to naively split all header values containing a comma into an Array, before attempting to match. This feels wrong. However, I don't know a better way of doing it. My Webmock-fu is weak.
davidbegin
added a commit
that referenced
this pull request
Sep 30, 2015
Threadsafe manticore client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.