Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for patch #625

Merged
merged 3 commits into from
Jun 1, 2016
Merged

Add support for patch #625

merged 3 commits into from
Jun 1, 2016

Conversation

pavel-jurasek
Copy link

@pavel-jurasek pavel-jurasek commented Jun 1, 2016 •
edited
Loading

This PR preparing WebMock to use this PR in CURB core:
taf2/curb#301

@bblimke
Copy link
Owner

bblimke commented Jun 1, 2016

Travis has some issues with it on jruby.

@pavel-jurasek
Copy link
Author

@bblimke should be fine now.

@bblimke
Copy link
Owner

bblimke commented Jun 1, 2016

Looks good. 👍 Thank you!

@bblimke bblimke merged commit 8d82115 into bblimke:master Jun 1, 2016
@lucasgomide
Copy link
Contributor

lucasgomide commented Jul 17, 2016 •
edited
Loading

@bblimke the commit from that merge was been reverted.
taf2/curb@9573ed5

Can we revert too ?

@lucasgomide lucasgomide mentioned this pull request Jul 18, 2016
Closed
lucasgomide added a commit to lucasgomide/webmock that referenced this pull request Jul 18, 2016
@lucasgomide
Revert "Merge pull request bblimke#625 from pavel-jurasek-bcgdv-com/j…
e495f41 
…urasek_patch_integration"

This reverts commit 8d82115, reversing
changes made to da15b1a.
lucasgomide added a commit to lucasgomide/webmock that referenced this pull request Jul 18, 2016
@lucasgomide
Revert "Merge pull request bblimke#625 from pavel-jurasek-bcgdv-com/j…
cd543b6 
…urasek_patch_integration"

This reverts commit 8d82115, reversing
changes made to da15b1a.
lucasgomide added a commit to lucasgomide/webmock that referenced this pull request Jul 18, 2016
@lucasgomide
Revert "Merge pull request bblimke#625 from pavel-jurasek-bcgdv-com/j…
d62d75f 
…urasek_patch_integration"

This reverts commit 8d82115, reversing
changes made to da15b1a.
lucasgomide added a commit to lucasgomide/webmock that referenced this pull request Jul 18, 2016
@lucasgomide
Revert "Merge pull request bblimke#625 from pavel-jurasek-bcgdv-com/j…
a10601a 
…urasek_patch_integration"

This reverts commit 8d82115, reversing
changes made to da15b1a.
lucasgomide added a commit to lucasgomide/webmock that referenced this pull request Jul 18, 2016
@lucasgomide
Revert "Merge pull request bblimke#625 from pavel-jurasek-bcgdv-com/j…
b66cfcd 
…urasek_patch_integration"

This reverts commit 8d82115, reversing
changes made to da15b1a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavel-jurasek @bblimke @lucasgomide