Implement #close on HTTP::Response::Streamer #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since HTTP::Response::Streamer is returned instead of a HTTP::Connection, and HTTP::Connection responds to #close, HTTP::Response::Streamer should then also respond to #close.
janko
force-pushed
the
add-close-to-http-response-streamer
branch
from
ed3dffa
to
d6a7370
Compare
|
@janko-m Thank you for this pull request! :) |
|
Released as version 3.1.0. I'm sorry for the delay releasing it. |
|
No problem, thank you for the release 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since HTTP::Response::Streamer is returned instead of a HTTP::Connection, and HTTP::Connection responds to #close, HTTP::Response::Streamer should then also respond to #close.
I encountered this error when some code wanted to manually close the connection: