-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hashdiff
Constant
#823
Conversation
Why This Change Is Necessary ======================================================================== The `hashdiff` gem is changing its constant and thus we need to do the same. How These Changes Address the Issue ======================================================================== Update `HashDiff` references to `Hashdiff`. Side Effects Caused By This Change ======================================================================== None known. ------------------------------------------------------------------------ Actions: * References #822
@jfelchner thank you. we can sync releases or the code can try to load Hashdiff constant and fallback to HashDiff is not present. |
@bblimke no problem! |
Once |
@bblimke because of webmock's popularity and the fact that the prior versions aren't pessimistically locked to There are some popular gems that are locked to the 1.x and 2.x versions. |
If you re-run the travis build, it should work, now that |
@teeparham Yep. At this point I'm just waiting for a reply from @bblimke |
@jfelchner Thanks for fixing this annoying warning. 👍 |
@bblimke can we get this merged? |
@jodosha strictly speaking, this won't remove the warning just yet. But it will as soon as we release |
@bblimke do you want me to create patches for v1 and v2 as well? |
@jfelchner not sure it's worth supporting these old releases. people can always set versions of hashdiff in their Gemfiles. Though feel free to prepare these. I can release them as well. I'll try to cut a new 3.x release tonight. |
@bblimke not a problem. Up to you. I just wanted to offer. :) |
For anyone else who wants to upgrade and remove the warning: I upgraded to webmock version
Then run |
Why This Change Is Necessary
The
hashdiff
gem is changing its constant and thus we need to do thesame.
How These Changes Address the Issue
Update
HashDiff
references toHashdiff
.Side Effects Caused By This Change
This will not remove the
hashdiff
warning error untilhashdiff
's1.0
version is released, at which point abundle update
will removethe warning.
Actions:
hashdiff
Uses Non-Standard Constant #822