Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hashdiff Constant #823

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Update Hashdiff Constant #823

merged 1 commit into from
Jun 4, 2019

Conversation

jfelchner
Copy link
Contributor

@jfelchner jfelchner commented May 28, 2019

Why This Change Is Necessary

The hashdiff gem is changing its constant and thus we need to do the
same.

How These Changes Address the Issue

Update HashDiff references to Hashdiff.

Side Effects Caused By This Change

This will not remove the hashdiff warning error until hashdiff's
1.0 version is released, at which point a bundle update will remove
the warning.


Actions:

Why This Change Is Necessary
========================================================================

The `hashdiff` gem is changing its constant and thus we need to do the
same.

How These Changes Address the Issue
========================================================================

Update `HashDiff` references to `Hashdiff`.

Side Effects Caused By This Change
========================================================================

None known.

------------------------------------------------------------------------
Actions:
  * References #822
@bblimke
Copy link
Owner

bblimke commented May 28, 2019

@jfelchner thank you. we can sync releases or the code can try to load Hashdiff constant and fallback to HashDiff is not present.

@jfelchner
Copy link
Contributor Author

@bblimke no problem! hashdiff 0.4.0 was just released and the PR should be safe to merge now.

@jfelchner
Copy link
Contributor Author

Once 0.4.0 is in the wild for a couple months, and your users have a chance to upgrade to latest, we'll release 1.0.

@jfelchner
Copy link
Contributor Author

jfelchner commented May 29, 2019

@bblimke because of webmock's popularity and the fact that the prior versions aren't pessimistically locked to hashdiff, we may want to make these same changes on the 1.x and 2.x branches and release new versions for them as well.

There are some popular gems that are locked to the 1.x and 2.x versions.

@teeparham
Copy link

If you re-run the travis build, it should work, now that 0.4.0 is released.

@jfelchner
Copy link
Contributor Author

@teeparham Yep. At this point I'm just waiting for a reply from @bblimke

@jodosha
Copy link

jodosha commented Jun 3, 2019

@jfelchner Thanks for fixing this annoying warning. 👍

@jfelchner
Copy link
Contributor Author

@bblimke can we get this merged?

@jfelchner
Copy link
Contributor Author

@jodosha strictly speaking, this won't remove the warning just yet. But it will as soon as we release hashdiff 1.0 and you bundle update.

@bblimke bblimke merged commit 42c0a96 into bblimke:master Jun 4, 2019
@jfelchner
Copy link
Contributor Author

@bblimke do you want me to create patches for v1 and v2 as well?

@bblimke
Copy link
Owner

bblimke commented Jun 4, 2019

@jfelchner not sure it's worth supporting these old releases. people can always set versions of hashdiff in their Gemfiles. Though feel free to prepare these. I can release them as well.

I'll try to cut a new 3.x release tonight.

@jfelchner
Copy link
Contributor Author

@bblimke not a problem. Up to you. I just wanted to offer. :)

@ndbroadbent
Copy link

For anyone else who wants to upgrade and remove the warning:

I upgraded to webmock version 3.6.0, which includes this change (renames the constant from HashDiff to Hashdiff). I also followed these instructions to upgrade to the hashdiff 1.0 beta:

gem 'hashdiff', ['>= 1.0.0.beta1', '< 2.0.0']

Then run bundle update hashdiff. This makes sure you are using the latest versions and will get rid of the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants