Make the StubSocket slightly more believable #988
Merged
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @rzane . Awesome! |
ElvinEfendi
reviewed
Jul 4, 2024
| do_start if @socket.is_a?(StubSocket) | ||
| if @socket.is_a?(StubSocket) | ||
| @socket&.close | ||
| @socket = nil |
There was a problem hiding this comment.
Why are these necessary? How is it better simulating net/http?
It causes issues when running tests with tools like https://github.com/shopify/toxiproxy where the test involves starting a successful HTTP connection to a local server, and then mimics that server failing using toxiproxy, and attempting another request. The exception raised is "undefined method `closed?' for nil", which is coming from https://github.com/ruby/net-http/blob/d39f1e35da0094759356a49a3c96fea84325c388/lib/net/http.rb#L2431.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #976 (comment)
#ssl_versionand#cipherto be defined. Though these methods are private, it's best if webmock can try to act like the Net::HTTP to avoid gems having to detect if WebMock is enabled.StubSocket#closeandStubSocket#closed?a bit more realistic as well.Net::HTTP#ipaddrwas broken becauseStubSocket#peeraddrwasn't defined.