Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncheck and Delete combination in a DictManager view causes a crash #71

Closed
rmcgurrin opened this issue Sep 11, 2015 · 1 comment
Closed
Assignees

Comments

@rmcgurrin
Copy link
Contributor

Steps to reproduce:
-Create 3 new Measurement filters
-Uncheck Filter2 and 'Remove' Filter1 ( see example below)
-This will cause a crash with a "Filter2" key value error

Expected behavior:
-No crash

example:
image

@rmcgurrin rmcgurrin self-assigned this Sep 11, 2015
rmcgurrin added a commit to rmcgurrin/PyQLab that referenced this issue Sep 18, 2015
BBN-Q#69
In the Looper Form of MeasFilterViews.enaml, test that the selected
filter is in the filter dictionary else return -1

BBN-Q#70
Added a childFilter to the StateComparator class because it was missing.

BBN-Q#71
In the QtListStrWidget, test if the enable changed when the labels are the same
and the label is in the item list. Also, only signal a name change when the
labels are not the same and the newlabel is not in the item list. In the old
version of code there are some conditions when on_edit is called that result in
the dictionary manager trying to rename an item that does not exist.

BBN-Q#72
Added a new feature to save config in a different directory and load a config
from a different directory.  After loading a config, the GUI will restart itself
for the changes to take effectively
rmcgurrin added a commit to rmcgurrin/PyQLab that referenced this issue Sep 24, 2015
BBN-Q#69
In the Looper Form of MeasFilterViews.enaml, test that the selected
filter is in the filter dictionary else return -1

BBN-Q#71
In the QtListStrWidget, test if the enable changed when the labels are the same
and the label is in the item list. Also, only signal a name change when the
labels are not the same and the newlabel is not in the item list. In the old
version of code there are some conditions when on_edit is called that result in
the dictionary manager trying to rename an item that does not exist.

BBN-Q#72
Added a new feature to save config in a different directory and load a config
from a different directory.  After loading a config, the GUI will restart itself
for the changes to take effectively
rmcgurrin added a commit to rmcgurrin/PyQLab that referenced this issue Sep 25, 2015
BBN-Q#69
In the Looper Form of MeasFilterViews.enaml, test that the selected
filter is in the filter dictionary else return -1

BBN-Q#71
In the QtListStrWidget, test if the enable changed when the labels are the same
and the label is in the item list. Also, only signal a name change when the
labels are not the same and the newlabel is not in the item list. In the old
version of code there are some conditions when on_edit is called that result in
the dictionary manager trying to rename an item that does not exist.

BBN-Q#72
Added a new feature to save config in a different directory and load a config
from a different directory.  After loading a config, the GUI will restart itself
for the changes to take effectively
blakejohnson added a commit that referenced this issue Sep 28, 2015
rmcgurrin added a commit that referenced this issue Sep 29, 2015
#69
In the Looper Form of MeasFilterViews.enaml, test that the selected
filter is in the filter dictionary else return -1

#71
In the QtListStrWidget, test if the enable changed when the labels are the same
and the label is in the item list. Also, only signal a name change when the
labels are not the same and the newlabel is not in the item list. In the old
version of code there are some conditions when on_edit is called that result in
the dictionary manager trying to rename an item that does not exist.

#72
Added a new feature to save config in a different directory and load a config
from a different directory.  After loading a config, the GUI will restart itself
for the changes to take effectively
@rmcgurrin
Copy link
Contributor Author

Fixed in 8c60b24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant