Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #69,#70,#71, and #72 #74

Closed
wants to merge 1 commit into from
Closed

Conversation

rmcgurrin
Copy link
Contributor

#69

In the Looper Form of MeasFilterViews.enaml, test that the selected
filter is in the filter dictionary else return -1
#70

Added a childFilter to the StateComparator class because it was missing.
#71

In the QtListStrWidget, test if the enable changed when the labels are the same
and the label is in the item list. Also, only signal a name change when the
labels are not the same and the newlabel is not in the item list. In the old
version of code there are some conditions when on_edit is called that result in
the dictionary manager trying to rename an item that does not exist.
#72

Added a new feature to save config in a different directory and load a config
from a different directory. After loading a config, the GUI will restart itself
for the changes to take effectively

BBN-Q#69
In the Looper Form of MeasFilterViews.enaml, test that the selected
filter is in the filter dictionary else return -1

BBN-Q#70
Added a childFilter to the StateComparator class because it was missing.

BBN-Q#71
In the QtListStrWidget, test if the enable changed when the labels are the same
and the label is in the item list. Also, only signal a name change when the
labels are not the same and the newlabel is not in the item list. In the old
version of code there are some conditions when on_edit is called that result in
the dictionary manager trying to rename an item that does not exist.

BBN-Q#72
Added a new feature to save config in a different directory and load a config
from a different directory.  After loading a config, the GUI will restart itself
for the changes to take effectively
@blakejohnson
Copy link
Collaborator

Rob, would you mind breaking out your fix of #70 so that we can discuss just that? The "childFilter" concept has largely been removed from the measurement filters, so I expect a different fix is needed.

@rmcgurrin
Copy link
Contributor Author

I'm closing this review and resubmitting the review with the #70 change backed out. I'll tackle a root cause for that separately.

@rmcgurrin rmcgurrin closed this Sep 24, 2015
@blakejohnson
Copy link
Collaborator

There's no need to close a pull request for that kind of change. Just refactor your local branch as you want, and then force push the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants