fix: extensions marked support=vulkan,vulkansc are no longer excluded #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is interesting...I was expecting an update to handling the "supported" attribute at some point in the future, but not so soon. I need to test a bit against 1.3.242 before merging this. It also looks like the implementation of vulkansc creates some duplicated types, struct members, etc. in vk.xml. I suspect that is the root cause of issue #20 that you opened. |
|
Closing this in favor of PR #41. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensions were missing when generating code from the latest
vk.xml. Seems to be due to them now being taggedsupported="vulkan,vulkansc"instead of justsupported="vulkan", which was not recognized by the XML query.Added a simple check that considers comma separated values instead of the attribute value filter.