fix(edges): type marker prop in EdgeProps

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
bcakmakoglu · Dec 6, 2022 · 029394e · 029394e
1 parent aed0845
commit 029394e
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 10 deletions.
diff --git a/.changeset/thin-fishes-move.md b/.changeset/thin-fishes-move.md
@@ -0,0 +1,5 @@
+---
+'@vue-flow/core': patch
+---
+
+Type `markerEnd` and `markerStart` in `EdgeProps`
diff --git a/packages/core/src/components/Edges/EdgeWrapper.ts b/packages/core/src/components/Edges/EdgeWrapper.ts
@@ -168,6 +168,7 @@ const EdgeWrapper = defineComponent({
                 targetNode: props.targetNode,
                 source: edge.source,
                 target: edge.target,
+                type: edge.type,
                 updatable: props.updatable,
                 selected: edge.selected,
                 animated: edge.animated,

diff --git a/packages/core/src/types/edge.ts b/packages/core/src/types/edge.ts
@@ -123,8 +123,8 @@ export interface EdgeProps<Data = ElementData, CustomEvents = {}> {
   id: string
   sourceNode: GraphNode
   targetNode: GraphNode
+  type?: keyof DefaultEdgeTypes | string
   label?: string | VNode | Component<EdgeTextProps> | Object
-  type?: string
   style?: CSSProperties
   sourceX: number
   sourceY: number
@@ -144,8 +144,8 @@ export interface EdgeProps<Data = ElementData, CustomEvents = {}> {
   labelBgBorderRadius?: number
   animated?: boolean
   updatable?: boolean
-  markerStart?: string
-  markerEnd?: string
+  markerStart: string
+  markerEnd: string
   curvature?: number
   interactionWidth?: number
   data: Data
@@ -159,7 +159,6 @@ export interface SmoothStepEdgeProps<Data = ElementData, CustomEvents = {}> exte
   sourceNode: GraphNode
   targetNode: GraphNode
   label?: string | VNode | Component<EdgeTextProps> | Object
-  type?: string
   style?: CSSProperties
   sourceX: number
   sourceY: number
@@ -179,8 +178,8 @@ export interface SmoothStepEdgeProps<Data = ElementData, CustomEvents = {}> exte
   labelBgBorderRadius?: number
   animated?: boolean
   updatable?: boolean
-  markerStart?: string
-  markerEnd?: string
+  markerStart: string
+  markerEnd: string
   borderRadius?: number
   offset?: number
   interactionWidth?: number

diff --git a/packages/pathfinding-edge/src/types.ts b/packages/pathfinding-edge/src/types.ts
@@ -21,8 +21,8 @@ export interface PathFindingEdgeProps extends EdgeProps<never> {
   labelBgPadding?: [number, number]
   labelBgBorderRadius?: number
   style?: CSSProperties
-  markerEnd?: string
-  markerStart?: string
+  markerEnd: string
+  markerStart: string
   sourceHandleId?: string
   targetHandleId?: string
 }
@@ -46,8 +46,8 @@ export interface PerfectArrowProps {
   labelBgPadding?: [number, number]
   labelBgBorderRadius?: number
   style?: CSSProperties
-  markerEnd?: string
-  markerStart?: string
+  markerEnd: string
+  markerStart: string
   sourceHandleId?: string
   targetHandleId?: string
   options?: ArrowOptions