Skip to content

Commit

Permalink
fix(core): hide graph until nodes are ready
Browse files Browse the repository at this point in the history
Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
  • Loading branch information
bcakmakoglu committed Feb 22, 2023
1 parent 6002c28 commit 204d103
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions packages/core/src/container/Viewport/Transform.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import NodeRenderer from '../NodeRenderer/NodeRenderer.vue'
import EdgeRenderer from '../EdgeRenderer/EdgeRenderer.vue'
import type { Dimensions } from '../../types'
const { id, viewport, dimensions, fitViewOnInit, emits, fitView, ...rest } = useVueFlow()
const { id, viewport, dimensions, fitViewOnInit, emits, fitView, onNodesInitialized, ...rest } = useVueFlow()
const untilDimensions = async (dim: Dimensions) => {
// if ssr we can't wait for dimensions, they'll never really exist
Expand All @@ -16,22 +16,27 @@ const untilDimensions = async (dim: Dimensions) => {
return true
}
let ready = $ref(false)
let isReady = $ref(false)
onNodesInitialized(() => {
setTimeout(() => {
// hide graph until nodes are ready, so we don't have jumping graphs (ssr for example)
isReady = true
}, 0)
})
onMounted(async () => {
// wait until proper dimensions have been established, otherwise fitView will have wrong bounds when called at paneReady
await untilDimensions(dimensions.value)
// hide graph until dimensions are ready, so we don't have jumping graphs (ssr for example)
ready = true
emits.paneReady({
id,
viewport,
dimensions,
fitViewOnInit,
fitView,
emits,
onNodesInitialized,
...rest,
})
Expand All @@ -50,7 +55,7 @@ export default {
<div
:key="`transform-${id}`"
class="vue-flow__transformationpane vue-flow__container"
:style="{ transform: `translate(${viewport.x}px,${viewport.y}px) scale(${viewport.zoom})`, opacity: ready ? undefined : 0 }"
:style="{ transform: `translate(${viewport.x}px,${viewport.y}px) scale(${viewport.zoom})`, opacity: isReady ? undefined : 0 }"
>
<EdgeRenderer />

Expand Down

0 comments on commit 204d103

Please sign in to comment.