Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

『砂塵戦機アーガス』のダイスを変更しました #642

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

Faceless192x
Copy link
Contributor

アーガスのダイスで一般判定に「成功レベル」を表示してほしい旨要望があったので、実装してみました。
使用方法等は変わらず、一般判定の成功時に「成功(+2)」などと成功レベルを併記するようにしました。
rubocop通過済みです。

お手隙の際に、ご確認くださいませ。

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (434f573) 95.60% compared to head (604566f) 95.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         341      341           
  Lines       19559    19560    +1     
  Branches     5094     5094           
=======================================
+ Hits        18700    18701    +1     
  Misses        859      859           
Files Changed Coverage Δ
lib/bcdice/game_system/SajinsenkiAGuS.rb 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ysakasin ysakasin merged commit 0a44d54 into bcdice:master Sep 20, 2023
8 checks passed
@ysakasin
Copy link
Member

@Faceless192x ありがとうございます! マージしました。

@Faceless192x Faceless192x deleted the update/AGuS1E branch September 23, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants