removed redundant throws clause in X509v3CertificateBuilder #1581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1580
X509v3CertificateBuilder
has overloadedaddExtension
methods, which callExtensionsGenerator
under the hood.If the extension is constructed from OID, critical flag and encoded extension value,
ExtensionsGenerator
may throwCertIOException
if anIOException
occurs during construction of the extension.However, if
Extension
object is passed - noIOException
can occur insideExtensionGenerator
and it doesn't throwCertIOException
as well.bc-java/core/src/main/java/org/bouncycastle/asn1/x509/ExtensionsGenerator.java
Lines 119 to 134 in 9279d29
Therefore, this checked exception
throws
clause is redundant inX509v3CertificateBuilder
.