Allow population of PGPSignatureSubpacketGenerator from given PGPSign… #848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atureSubpacketVector
Hey :)
I'm struggling to extend the expiration date of a keyring while preserving the signature subpackets of the previous self-signature.
This PR allows for the
PGPSignatureSubpacketGenerator
to be prepopulated with subpackets of a givenPGPSignatureSubpacketVector
.I also prevent some packet types from being added into the vector multiple times where it makes sense to prevent this.
This is being done by switching from an ominous list of subpackets to members for the different subpacket types.
The changes are aimed to be as backwards compatible as possible, so where the name of a method doesn't match what it does (the case with some setters) I deprecated the unsuitable method and forward method calls to a method that is more suitably named.
Let me know what you think of this change or if I can improve it somehow.