[SEVERE] Blake2bDigest: fix wrong buffer passed to_compress when _digestLength < 64
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct variable to be passed to `_compress` is `_buffer`, that was populated 3 lines above, not the method parameter `inp`. To test this changed line you should create a `Blake2bDigest` with `digestSize` = 32. See equivalent Java implementation line as reference: https://github.com/bcgit/bc-java/blob/master/core/src/main/java/org/bouncycastle/crypto/digests/Blake2bDigest.java#L353
gmpassos
changed the title
_compress when _digestLength < 64_compress when _digestLength < 64
|
Hi, Thanks for reporting this! It has been merged and will be synced shortly along with a new release. MW |
gmpassos
added a commit
to gmpassos/argon2
that referenced
this pull request
Jun 18, 2021
- Now using fixed `pointycastle` `Blake2b`: - pointycastle: ^3.1.2 - bcgit/pc-dart#108 - Removed `argon2_blake2b.dart`, not necessary anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct variable to be passed to
_compressis_buffer, that was populated 3 lines above, not the method parameterinp.To test this changed line you should create a
Blake2bDigestwithdigestSize= 32.See equivalent Java implementation line as reference:
https://github.com/bcgit/bc-java/blob/master/core/src/main/java/org/bouncycastle/crypto/digests/Blake2bDigest.java#L353