Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Argon2 Password Hashing #23

Closed
AKushWarrior opened this issue Jun 9, 2020 · 9 comments
Closed

Add Argon2 Password Hashing #23

AKushWarrior opened this issue Jun 9, 2020 · 9 comments

Comments

@AKushWarrior
Copy link
Contributor

Argon2 is the closest thing to a standard in the password hashing space. It should be an option that we provide.

Implementation Link: https://github.com/bcgit/bc-java/blob/master/core/src/main/java/org/bouncycastle/crypto/generators/Argon2BytesGenerator.java

@AKushWarrior
Copy link
Contributor Author

I'm going to take this. Will report back in a few days...

@AKushWarrior
Copy link
Contributor Author

It's been more than a few days. Meant to start this a while ago, but I've been busy lately. Maybe I'll commit post-release?

@konsultaner
Copy link
Contributor

@AKushWarrior maybe it helps. There is a pure dart implementation of blake2: https://github.com/james-alex/blake2

@AKushWarrior
Copy link
Contributor Author

We have blake2b in this library. I've just been insanely busy for a while.

@konsultaner
Copy link
Contributor

@AKushWarrior ok, sorry. I just wanted to help. As a developer being busy is your burden ;). What I'm goining to try is to crosscompile the reference implementation and try to ffi it. Lets see where this goes...

@AKushWarrior
Copy link
Contributor Author

@konsultaner No need to apologize. I'm a little frustrated that I haven't been able to work on some open-source projects more, but you're right to say that my burden is to labor on.

It looks like there's no pure-dart implementation, but there is this: https://pub.dev/packages/dargon2
I have no idea of the quality, but it does seem to be what you were planning to do.

@konsultaner
Copy link
Contributor

@AKushWarrior Thanks for that link. I want to have a build for all plattforms including the web. So it needs to compile to wasm as well. This is more an exercise too digg into that topic.

@gmpassos
Copy link
Contributor

FYI: #108

@gmpassos
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants