Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSP-7664 FT-REG: When cancelling, the confirmation modal should be consistent around different types of files #3747

Merged
merged 10 commits into from
Jan 31, 2024
Merged

PSP-7664 FT-REG: When cancelling, the confirmation modal should be consistent around different types of files #3747

merged 10 commits into from
Jan 31, 2024

Conversation

asanchezr
Copy link
Collaborator

No description provided.

@asanchezr asanchezr added the bug Something isn't working label Jan 29, 2024
@asanchezr asanchezr self-assigned this Jan 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (bff2a87) 75.58% compared to head (6eae2b6) 74.23%.

❗ Current head 6eae2b6 differs from pull request most recent head 13a2cc9. Consider uploading reports for the commit 13a2cc9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3747      +/-   ##
==========================================
- Coverage   75.58%   74.23%   -1.35%     
==========================================
  Files        1447      954     -493     
  Lines       37535    20641   -16894     
  Branches     7058     5949    -1109     
==========================================
- Hits        28369    15323   -13046     
+ Misses       8887     5318    -3569     
+ Partials      279        0     -279
Flag Coverage Δ
unittests 74.23% <36.00%> (-1.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/components/common/CancelConfirmationModal.tsx 87.50% <100.00%> (ø)
...ce/frontend/src/components/common/GenericModal.tsx 92.50% <100.00%> (+0.09%) ⬆️
...eate/components/modals/CancelConfirmationModal.tsx 100.00% <ø> (ø)
...d/src/features/mapSideBar/lease/LeaseContainer.tsx 7.54% <ø> (ø)
...atures/mapSideBar/project/ProjectContainerView.tsx 36.66% <ø> (ø)
source/frontend/src/hooks/useModalContext.tsx 100.00% <ø> (ø)
...eBar/shared/update/properties/UpdateProperties.tsx 74.02% <42.85%> (-3.01%) ⬇️
...res/mapSideBar/property/MotiInventoryContainer.tsx 49.09% <14.28%> (-2.84%) ⬇️
...features/mapSideBar/research/ResearchContainer.tsx 54.38% <14.28%> (-1.47%) ⬇️

... and 493 files with indirect coverage changes

@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit c33f4d3 into bcgov:dev Jan 31, 2024
7 checks passed
devinleighsmith added a commit that referenced this pull request Feb 1, 2024
@asanchezr @stairaku
@github-actions @pravkuma14 @devinleighsmith @dfilteau @FuriousLlama @eddherrera @ap-quartech
UAT Release - IS72 (#3761)
4133f3d 
* Refactoring of modals and changes on Smoke Test Automation Test Cases

* Automation refactoring - modals, updating fields on Compensation, Digital Docs for Property Management

* Refactoring modals

* Automation refactoring - modals, updating fields on Compensation, Digital Docs for Property Management

* Refactoring modals

* Automation updates

* Automation updates

* Contacts elements update

* Digital Documents subtitles fix

* CI: Bump version to v5.0.0-71.25

* Version bump (#3729)

* CI: Bump version to v5.0.0-72.1

* Disposition Files initial Automation

* CI: Bump version to v5.0.0-72.2

* Psp 7611 - ensure undefined/null handled correctly by contact parsers. (#3730)

* handle null and undefined contact fields.

* remove debugger;

* CI: Bump version to v5.0.0-72.3

* PSP-7578 Remove Project and Product from Header of Disposition File (#3734)

* Fix runtime error when user guid is invalid

* Remove Project and Product from Header of Disposition File

* Test corrections

* CI: Bump version to v5.0.0-72.4

* psp-7630 ensure that properties added directly to inventory have the … (#3728)

* psp-7630 ensure that properties added directly to inventory have the correct flags set.

* test correction.

Signed-off-by: devinleighsmith <devinleighsmith@gmail.com>

---------

Signed-off-by: devinleighsmith <devinleighsmith@gmail.com>

* CI: Bump version to v5.0.0-72.5

* psp-7609 ensure that changing the status of an acq file generates a note. (#3726)

* CI: Bump version to v5.0.0-72.6

* lint correction. (#3733)

* CI: Bump version to v5.0.0-72.7

* IS-72.00 Database Schema (#3716)

* IS-72.00 Database Schema

PSP_PIMS S72.00 Sprint 72 2024-Jan-16
- Altered tables:
  - PIMS_PROPERTY
  - PIMS_PROPERTY_HIST
- Altered build scripts:
  - 002_PSP_PIMS_Build.sql
  - 020_DML_PIMS_STATIC_VARIABLE.sql
  - 148_DML_PIMS_DSP_CHKLST_ITEM_TYPE.sql
- Added test scripts:
  - 071_PIMS_PROPERTY_CONTACT.sql
- Altered test scripts:
  - 005_DML_LEASE_PROPERTY.sql
- Requires additional metadata to meet standards

* fixed build not matching alter up result

* aligned latest folder

---------

Co-authored-by: Manuel Rodriguez <marobej@gmail.com>

* CI: Bump version to v5.0.0-72.8

* generated scaffold and removed lingering files (#3738)

* CI: Bump version to v5.0.0-72.9

* Disposition checklist automation

* fixed the disposition bug 7582

* CI: Bump version to v5.0.0-72.10

* Added Reordering of the DISPLAY_ORDER Columns (#3742)

Reordered the display order following the insertion/deletion of the PIMS_DSP_CHKLST_ITEM_TYPE table.

* CI: Bump version to v5.0.0-72.11

* PSP-7296 : Create/Edit Sales Details (Disposition) (#3731)

* CI: Bump version to v5.0.0-72.12

* PSP-7639 PIMS HIST Table fix commit (#3743)

Fix on missing Historical rows that were identified on 3 tables in UAT database

1.PIMS_INSURANCE

2.PIMS_LEASE_TENANT

3.PIMS_PROPERTY_LEASE

* CI: Bump version to v5.0.0-72.13

* PSP-7509 : Allow Contractor to Create or Edit Disposition File (#3735)



Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com>

* CI: Bump version to v5.0.0-72.14

* Disposition File details, documents and notes. Refactoring on File Properties

* PSP-7510 : Disallow Contractor to Remove Themself from Disposition File (#3745)

Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com>

* CI: Bump version to v5.0.0-72.15

* correct disposition list view file number. (#3736)

* CI: Bump version to v5.0.0-72.16

* Offers and sales tab automation

* disposition offers and sales tab

* Psp 7614, 7657, 7626, 7610 assorted text corrections. (#3737)

* text corrections.

* correct title text.

* psp-7657 fix modal buttons.

* test updates.

* lint fixes.

* CI: Bump version to v5.0.0-72.17

* CI: Bump version to v5.0.0-72.18

* Refactoring and Disposition file automation

* Merge conflicts between local and remote

* Disposition files - Offers and sale create and update

* Deleting AcquisitionProperties class, replaced by SharedFileProperties

* Text changes (#3752)

* CI: Bump version to v5.0.0-72.19

* correct message text. (#3749)

* CI: Bump version to v5.0.0-72.20

* Refactoring LeaseTenants class

* CI: Bump version to v5.0.0-72.21

* PSP-6668 FT: Acquisition File: Compensation: Show error modal instead of toast when total allowable compensation value is less than total compensation value (#3755)

* Show modal popup with warning message for total allowable compensation

* Test corrections

* CI: Bump version to v5.0.0-72.22

* PSP-7664 FT-REG: When cancelling, the confirmation modal should be consistent around different types of files (#3747)

* Increase the default width of modals

* Rename file

* Refactor duplicate code

* Verbiage update

* Update snapshots

* Text updates

* Test corrections

* CI: Bump version to v5.0.0-72.23

* psp-7680 add agreement status type to agreement export. (#3751)

* add agreement status type to agreement export.

* test corrections.

* CI: Bump version to v5.0.0-72.24

* Pipeline updates (#3756)

* add keycloak sync to all pipelines.
add uat hotfix and pre-release hotfix pipelines.
update builds/keycloak sync to support new configuration.

* correct uat secret name

* add prod secrets for keycloak sync

* correct typo.

* CI: Bump version to v5.0.0-72.25

---------

Signed-off-by: devinleighsmith <devinleighsmith@gmail.com>
Co-authored-by: Sue Tairaku <sue.tairaku@gmail.com>
Co-authored-by: Sue Tairaku <42981334+stairaku@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: praveen <praveen.porumalla@quartech.com>
Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com>
Co-authored-by: Doug Filteau <dfilteau@users.noreply.github.com>
Co-authored-by: Manuel Rodriguez <marobej@gmail.com>
Co-authored-by: pravkuma14 <133119915+pravkuma14@users.noreply.github.com>
Co-authored-by: Eduardo <eddherrera@users.noreply.github.com>
Co-authored-by: ap-quartech <146900628+ap-quartech@users.noreply.github.com>
Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com>
@asanchezr asanchezr deleted the psp-7664-bug branch February 2, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FuriousLlama FuriousLlama FuriousLlama approved these changes

@devinleighsmith devinleighsmith devinleighsmith approved these changes

Assignees

@asanchezr asanchezr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asanchezr @FuriousLlama @devinleighsmith