Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset formatting fix #1016

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Dataset formatting fix #1016

merged 3 commits into from
Mar 26, 2024

Conversation

ikethecoder
Copy link
Member

@ikethecoder ikethecoder commented Mar 22, 2024 •
edited
Loading

New rendering of markdown on the API Directory detail page:

image

🚀 Feature branch deployment: https://api-services-portal-feature-dataset-markdown.apps.silver.devops.gov.bc.ca

rustyjux
rustyjux approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@rustyjux rustyjux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
In addition to the markdown sample dataset, I viewed the BC Route Planner item through the mock and I assume the content for this item was derived from the BCDC and so we shouldn't be creating any problems with existing datasets.

src/nextapp/shared/styles/markdown.module.css Show resolved Hide resolved
@ikethecoder ikethecoder requested a review from Elson9 March 25, 2024 21:30
@rustyjux
Copy link
Contributor

Also wondering about updating mock server docs - https://github.com/bcgov/api-services-portal?tab=readme-ov-file#mock-server
Seems to be as simple as running npm run nextapp-dev (making sure nothing else is running in docker). Are the other bits still relevant or accurate?

  • Next and GWA API_ROOT
  • Updating mock server schemas

@ikethecoder ikethecoder merged commit d52aa93 into dev Mar 26, 2024
5 checks passed
@ikethecoder ikethecoder deleted the feature/dataset-markdown branch March 26, 2024 19:01
nirajCITZ pushed a commit that referenced this pull request Mar 28, 2024
@ikethecoder @nirajCITZ
Dataset formatting fix (#1016)
1e87b67 
* add a nextapp-dev script

* improve the format of the dataset

* upd mock for dataset and upd css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elson9 Elson9 Elson9 approved these changes

@rustyjux rustyjux rustyjux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikethecoder @rustyjux @Elson9