v1.5.3 #28
Merged
v1.5.3 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem state: Images are not uploaded from the Bat Survey and Aerial Telemetry screens. Problem reason: Uploading images is not implemented neither on FE nor on BE. Detected in the branch: main Conditions to reproduce the issue: Create a bat survey or fill in the aerial telemetry form, attach images to them, and push the changes to the server. Images are not saved anywhere. Possible workarounds without the fix: No workarounds. Changes: BE: endpoint /image/upload for uploading an arbitrary number of images. Uploaded images are saved under random names. Currently, they are stored in uploads/images under app's working directory. FE: Before the records are sent to the server, a first pass is performed. Looping over the records, for each record its images are uploaded, and the record is "fixed" in the sense that image objects are replaced by file names of saved images returned from the server. Subsequently, "fixed" records are pushed to the server. A minor unrelated change: automatic pulling the bridges and animals is added to the Login screen. Risk factors: Syncing the records and logging in may be affected. Risk: Medium
…ed-photos-arent-saved-anywhere [BCGOVWILD-82] Uploading photos
Problem reason: Empty triangulation string sent to the server was not interpreted properly. Detected in the branch: main Conditions to reproduce the issue: Create and submit a "Telemetry Data" report. Possible workarounds without the fix: Unknown Changes: 1. FE internally saves triangulation when "Add entry" and "Triangulate" buttons are pressed. 2. Correct triangulation value (possibly empty string) is sent to BE if "use triangulation" is selected. Otherwise, "null" triangulation is sent. 3. BE interprets the empty string as an empty array of triangulation entries. 4. Code causing errors on empty comments is corrected. Risk factors: "Telemetry" and "Telemetry Triangulation" screens. Risk: Low.
…ed to Aerial telemetry
Problem reason: An off-by-one error when the month was computed. Detected in the branch: main Conditions to reproduce the issue: Open the Transect screen and make sure that auto-filled months are wrong. Possible workarounds without the fix: No. Changes: 1. Fix the off-by-one error. 2. It is required that the "Date and Time" input should be editable. In order to use native date and time picker, the input is split in "Date" and "Time" Risk factors: Transect screen. Risk: Low.
Feature/83 gps
Pull changes from the server on login and on sync even if there is no…
Fix coordinates min value validation
Replace unsynced bridge if it was edited instead of adding a new record
Problem reason: The input fields and columns in DB tables were not implemented. One unneeded input was present. Detected in the branch: main Changes: - editable inputs for date and time were added to the Bat Survey and Aerial Telemetry screens - corresponding columns added to tables - infrastructure implemented The tables still store the automatic creation timestamp in the "timestamp" column. Risk factors: Bat Survey and Aerial Telemetry screens Risk: Low
…r its creation. Problem reason: Navigaton does not destroy the screens, so the internal state of the lists is preserved. For example, if the user creates a bridge and goes back to the Bridge List, the Bridge List still displayes outdated list of bridges stored in its local state. Detected in the branch: main Conditions to reproduce the issue: Go to the Bridge List, add a bridge and go back to the Bridge List. The newly created bridge does not appear in the list. Same for editing the name of the bridge. Same for Animal List. Possible workarounds without the fix: Go to Dashboad and return to the Bridge List; the updated list is displayed. Changes: Use the isFocused hook and destroy the stateful component when the Bridge List looses focus. Thus, the state is reinitialized when the user is back. Same for animals. Risk factors: Bridge List, Bridge Form, Animal List, Animal Form. Risk: Medium. Recommendations for QA: Please make sure that the fix works properly on iOS.
Problem reason:
The onPress callback of a controlled BouncyCheckbox widget was using the
isChecker argument, which is explicitly prohibited by the docs:
The onPress callback will NOT receive the next isChecked when
disableBuiltInState is used.
Detected in the branch:
main
Conditions to reproduce the issue:
When creating a bridge, try clicking on a selected "Bridge is for"
option. Nothing happens.
Possible workarounds without the fix:
No workarounds.
Changes:
Modify the onPress callback not to use arguments.
Risk factors:
Bridge Form screen.
Risk:
Low.
…ect-survey-the-date-and-time-field [BCGOVWILD-101] [Transect Survey] Date and time field.
…ulation-error-message [BCGOVWILD-36] Telemetry: error message fixed
…idge-animal-is-not-displayed-in-the-list [BCGOVWILD-96] [Bridges list][Animals list] The Bridge/Animal isn't displayed in the list right after its creation.
…emetry-there-is-no-the-date-and-time-field-there-is-time-of-location # Conflicts: # app/BCWildlife/screens/AerielTelemetry/AerialTelemetryDataFormScreen.js # app/BCWildlife/screens/AerielTelemetry/parseAerialTelemetryForm.js # app/BCWildlife/screens/BatSurvey/BatSurveyFormScreen.js # backend/.gitignore # backend/src/apis/sync/service/syncBats.js
…-survey-aerial-telemetry-there-is-no-the-date-and-time-field-there-is-time-of-location [BCGOVWILD-84] [BCGOVWILD- 86] bat survey aerial telemetry there is no date and time field; there is time of location
…-cant-be-unselected # Conflicts: # app/BCWildlife/screens/Bridges/BridgeFormScreen.js
…idge-is-for-option-cant-be-unselected [BCGOVWILD-95] [Create Bridge][Edit Bridge] The Bridge is for option can't be unselected.
[Release] Patch version incremented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.