Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-579: Create and Edit: Animals and Animal Captures #1280

Closed
wants to merge 53 commits into from

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Apr 30, 2024

Links to Jira Tickets

  • N/A
  • Refactors the Manage Animals-related pages to follow SIMS design patterns

Description of Changes

  • Create/edit animal workflow
  • Create/edit capture workflow
  • Animal profile to display

Testing Notes

Requires bcgov/critterbase-api#53, which fixes a bug when deleting multiple critter attributes (markings, measurements, etc.)

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 5.45213% with 711 lines in your changes are missing coverage. Please review.

Project coverage is 51.03%. Comparing base (f019719) to head (e84621b).

Current head e84621b differs from pull request most recent head aeae822

Please upload reports for the commit aeae822 to get more accurate results.

Files Patch % Lines
.../animals/profile/captures/edit/EditCapturePage.tsx 0.00% 82 Missing ⚠️
...mals/profile/captures/create/CreateCapturePage.tsx 0.00% 69 Missing ⚠️
...c/features/surveys/animals/edit/EditAnimalPage.tsx 0.00% 66 Missing ⚠️
...atures/surveys/animals/create/CreateAnimalPage.tsx 0.00% 56 Missing ⚠️
...features/surveys/animals/list/SurveyAnimalList.tsx 0.00% 52 Missing ⚠️
...create/form/location/CaptureLocationMapControl.tsx 0.00% 48 Missing ⚠️
...tures/create/form/markings/CaptureMarkingsForm.tsx 0.00% 28 Missing ⚠️
...logical-units/components/EcologicalUnitsSelect.tsx 0.00% 23 Missing ⚠️
...captures/components/AnimalCaptureCardContainer.tsx 0.00% 22 Missing ⚠️
app/src/contexts/animalPageContext.tsx 8.69% 21 Missing ⚠️
... and 41 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1280      +/-   ##
==========================================
- Coverage   52.45%   51.03%   -1.42%     
==========================================
  Files         580      595      +15     
  Lines       16785    17136     +351     
  Branches     2602     2670      +68     
==========================================
- Hits         8805     8746      -59     
- Misses       7396     7804     +408     
- Partials      584      586       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label May 23, 2024
@NickPhura NickPhura self-assigned this May 23, 2024
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
5.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@NickPhura NickPhura marked this pull request as ready for review May 24, 2024 22:05
@NickPhura NickPhura changed the title Create and Edit: Animals and Animal Captures SIMSBIOHUB-579: Create and Edit: Animals and Animal Captures May 24, 2024
@NickPhura
Copy link
Collaborator

Replaced by #1291

@NickPhura NickPhura closed this May 24, 2024
@NickPhura NickPhura deleted the manage-animals branch May 24, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants