-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select/dropdown - improve error handling and focus state #390
base: main
Are you sure you want to change the base?
Conversation
Leaving this in draft for the moment, currently having trouble validating whether the |
Folding some additional tweaks into this PR:
(Took a couple of wrong turns and broke everything along the way, please disregard the commit/revert spam in the middle!) |
This PR contains minor tweaks to the Select component, to address the issues documented in #388 (based on work done for #389):
<Button>
element when theisInvalid
prop is passedFieldError
andValidationResult
. Creates an error message slot underneath the Select<Button>