Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select/dropdown - improve error handling and focus state #390

Merged
merged 13 commits into from
Jul 17, 2024
Merged

Select/dropdown - improve error handling and focus state #390

merged 13 commits into from
Jul 17, 2024

Commits on Jun 20, 2024

  1. adds styled error message slot using ValidationResult and FieldError

    @mkernohanbc
    mkernohanbc committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    a56cd53 View commit details
    Browse the repository at this point in the history

  2. adds error icon when isInvalid is true

    @mkernohanbc
    mkernohanbc committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1c0c452 View commit details
    Browse the repository at this point in the history

  3. add new focus state styling

    @mkernohanbc
    mkernohanbc committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    45d643e View commit details
    Browse the repository at this point in the history

  4. adjust spacing between label and button

    @mkernohanbc
    mkernohanbc committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    541ad99 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. fixes spacing and styling of input label

    @mkernohanbc
    mkernohanbc committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    19c1b3b View commit details
    Browse the repository at this point in the history

  2. Revert "fixes spacing and styling of input label" 

    This reverts commit 19c1b3b.
    @mkernohanbc
    mkernohanbc committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c06b997 View commit details
    Browse the repository at this point in the history

  3. Revert "adjust spacing between label and button" 

    This reverts commit 541ad99.
    @mkernohanbc
    mkernohanbc committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e1f4309 View commit details
    Browse the repository at this point in the history

  4. reverting unnecessary/broken styling tweaks, include only label spaci… 

    …ng fixes
    @mkernohanbc
    mkernohanbc committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    bef7760 View commit details
    Browse the repository at this point in the history

  5. errorMessage slot uses small body

    @mkernohanbc
    mkernohanbc committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    332eb56 View commit details
    Browse the repository at this point in the history

  6. replace instances of margin tokens used in padding statements

    @mkernohanbc
    mkernohanbc committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a730613 View commit details
    Browse the repository at this point in the history

  7. add padding to error message and expose FieldError in 'invalid' story

    @mkernohanbc
    mkernohanbc committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f602566 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. alternative fix for margins

    @mkernohanbc
    mkernohanbc committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6805b3f View commit details
    Browse the repository at this point in the history

  2. simplify optional/required labelling

    @mkernohanbc
    mkernohanbc committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f415819 View commit details
    Browse the repository at this point in the history