Refactor Siphons Fetch Source Github File into smaller files #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricksimonian
added
task: refactor
patricksimonian
added
the
status: not ready for merge
This was referenced Dec 20, 2018
patricksimonian
force-pushed
the
imp/siphon-source-type-refactor
branch
from
573b25b
to
2464e89
Compare
patricksimonian
commented
Dec 21, 2018
patricksimonian
removed
the
status: not ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This file was getting over 500 lines of code. Broke it up into smaller files and made more of a convention of how authored source type routines should be made.
NOTE this PR is not ready to merge
It requires #212 to be merged and this PR rebased on top of it (the merge commit to master) since this branch is based off of #212
/bot-ignore-length