This repository has been archived by the owner on Nov 25, 2020. It is now read-only.
Add resource limits to OpenShift deployments. #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
|
I went ahead and set the limits in |
|
Addresses; #217 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added resource limits to the agents and dflow since the new OS policy is causing issues when a new revision is merged into GitHub: nothing will deploy since we don't have "room" for additional best effort pods.
I applied all the limits to
dev, waiting for a confirmation that they look good to move forward withtestas well.The numbers are an educated guess, if they look good to you I'd say we merge the change and keep an eye open in case we need to tweak them.