19191 Updated models in legal-api to use NAICS fields in AlternateName #2396
Conversation
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
There was a problem hiding this comment.
This doesn't look right to me.
Afaik a business can have a NAICS and its DBAs can.
Not every business will have a DBA or Assumed name, so that section wouldn't work.
Also, a business can have many DBAs (so a one-or-none would blow up).
We have some with many 10s of DBA names
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
chenhongjing
changed the title
|
|
@chenhongjing as per our conversation, we can just update the alternate_names model to have the new NAICS fields for this ticket/PR. I will be creating some tickets to deal with integrating alternate name with rest of the code. |
| @@ -786,9 +786,22 @@ def find_by_legal_name(cls, legal_name: str = None): | |||
| @classmethod | |||
| def find_by_identifier(cls, identifier: str = None): | |||
| """Return a Business by the id assigned by the Registrar.""" | |||
| if not identifier or not cls.validate_identifier( | |||
There was a problem hiding this comment.
This sync with the method at common data model https://github.com/bcgov/lear/blob/feature-legal-name/python/common/business-registry-model/src/business_model/models/legal_entity.py#L931
Issue #: /bcgov/entity#19191
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).