[MDS-5715] Project Agent #2918
Merged
[MDS-5715] Project Agent #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther files, unused imports.
…r address, allow some international addresses, put on validation and make a new post code method that works with hooks structure. Fixed an alignment issue I noticed on Actions menu on core. Don't navigate to a new page on the form if there are errors
taraepp
added
🌶 Enhancement
taraepp
requested review from
simensma-fresh,
henryoforeh-dev,
matbusby-fw,
isuru-aot and
asinn134
| export const getFormattedProjectSummary = createSelector( | ||
| [getProjectSummary, getProject], | ||
| (summary, project) => { | ||
| let formattedSummary = { ...summary, authorizationOptions: [] }; | ||
| const agent = formatProjectSummaryAgent(summary.agent); |
There was a problem hiding this comment.
Will this throw an error if agent is null or undefined? I can't remember if strict null checks is enabled in our code base or not.
There was a problem hiding this comment.
agent doesn't have to be defined, but summary does. I think it must always be defined because it throws no errors on new entries.
henryoforeh-dev
previously approved these changes
Jan 25, 2024
taraepp
force-pushed
the
mds-5715-project-agent
branch
from
c7f168a
to
8570427
Compare
|
|
|
|
henryoforeh-dev
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5715
MDS-5739
Why are you making this change? Provide a short explanation and/or screenshots
