Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes part 3 #1433

Merged
merged 15 commits into from
Mar 7, 2024
Merged

Bug fixes part 3 #1433

merged 15 commits into from
Mar 7, 2024

Conversation

semmatti
Copy link
Contributor

@semmatti semmatti commented Mar 7, 2024

Issue #:
bcgov/entity#20204
bcgov/entity#20155
bcgov/entity#20145
bcgov/entity#20073

Description of changes:
Part of the Vue 3 upgrade.
This PR implements the fixes for the tickets listed above. Additionally the following refactors were performed:

  • renamed runManualRecipe to fetchAndLoadRecipeData
  • changed error dialog style
  • replaced response.status === 200 with response.ok
  • fix admin link showing as always highlighted in PR builds
  • renamed and reorganized reset functions in examine store

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@semmatti
Copy link
Contributor Author

semmatti commented Mar 7, 2024

/gcbrun

@semmatti
Copy link
Contributor Author

semmatti commented Mar 7, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1433-a6eqa3ut.web.app

@rarmitag rarmitag merged commit c29fb3f into bcgov:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants