17206 implement society NR flows #651
Conversation
| ], | ||
| REH: [ | ||
| EntityType.CR, | ||
| EntityType.CP, | ||
| EntityType.CC, | ||
| EntityType.UL, | ||
| EntityType.FI, | ||
| EntityType.BC | ||
| EntityType.BC, | ||
| EntityType.SO | ||
| ], | ||
| CHG: entityTypesBC.filter(ent => ent !== EntityType.PAR && ent !== EntityType.PA), |
There was a problem hiding this comment.
Any change needed for CHG? (I see PAR in there, which is a designation....?
Why is SO already part of MVE list?
There was a problem hiding this comment.
Sorry I am not familiar with this part. It is old code.
There was a problem hiding this comment.
Can you test around this code to see what it might do and whether it works correctly? Ask Mihai for help if needed.
| @@ -103,6 +103,11 @@ export class CommonMixin extends Vue { | |||
| return supportedEntites.includes(nr?.entity_type_cd) | |||
| } | |||
|
|
|||
| /** in case Societies NR needs to be released AFTER the way of navigating changes (feature branch) */ | |||
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-651-dk4f535f.web.app |
|
@severinbeauvais I've unit tested. @pwei1018 provided a temporary url for review. Does it mean the code merge will be applied after it has been tested? |
devops/vaults.env
Outdated
| @@ -10,6 +10,7 @@ VUE_APP_DASHBOARD_URL="op://web-url/$APP_ENV/business/DASHBOARD_URL" | |||
| VUE_APP_ENTITY_SELECTOR_URL="op://web-url/$APP_ENV/entity-selector/ENTITY_SELECTOR_URL" | |||
| VUE_APP_PAYMENT_PORTAL_URL="op://web-url/$APP_ENV/pay/PAYMENT_PORTAL_URL" | |||
| VUE_APP_SITEMINDER_LOGOUT_URL="op://web-url/$APP_ENV/siteminder/SITEMINDER_LOGOUT_URL" | |||
| VUE_APP_SOCIETIES_ONLINE_HOME_URL="op://web-url/$APP_ENV/bcregistry/SOCIETIES_URL/" | |||
There was a problem hiding this comment.
You need to remove the '/' at the end of string.
Eve, the temporary URL is automatically generated after anyone commenting |
|
@JazzarKarim please commit /gcbrun again because I have a new commit. Thanks. |
|
Temporary Url for review: https://namerequest-dev--pr-651-dk4f535f.web.app |
Sorry Eve, I just saw this. Sure thing! Btw, you can also run the command yourself like just what happened 👍 |
Karim may have answered this... The PR temporary URL allows preliminary testing before the PR is merged. If you're asking about the feature branch -- we will need a PR to merge the feature branch into main, once everything is complete. Ask again if you still have questions. |
* implement society NR flows * implement society * update version * according to code review * according to code review * according to code review * FF enable-society value is disabled * according to code review * remove '/' from url
* implement society NR flows * implement society * update version * according to code review * according to code review * according to code review * FF enable-society value is disabled * according to code review * remove '/' from url
* implement society NR flows * implement society * update version * according to code review * according to code review * according to code review * FF enable-society value is disabled * according to code review * remove '/' from url
* implement society NR flows * implement society * update version * according to code review * according to code review * according to code review * FF enable-society value is disabled * according to code review * remove '/' from url
* implement society NR flows * implement society * update version * according to code review * according to code review * according to code review * FF enable-society value is disabled * according to code review * remove '/' from url
Issue #: /bcgov/entity#17206
Description of changes:
implement society NR flows.
new environment variable: VUE_APP_SOCIETIES_ONLINE_HOME_URL="https://dev.bcregistry.ca/societies/"
new feature flag: enable-society
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).