17692 Add additional corp types to entity type mapping #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodube-aot
commented
Sep 20, 2023
leodube-aot
requested review from
severinbeauvais,
ketaki-deodhar and
JazzarKarim
src/components/new-request/search-components/business-lookup-fetch.vue
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-704-rqyba5nq.web.app |
src/components/new-request/search-components/business-lookup-fetch.vue
Outdated
Show resolved
Hide resolved
severinbeauvais
approved these changes
Sep 22, 2023
|
@ketaki-deodhar @JazzarKarim @vysakh-menon If anyone has some time today can they review this PR please? |
JazzarKarim
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#17692
Description of changes:
legalTypepassed in the entities search query string inbusiness-lookup-services.tsneeds to be a valid entity type in namex. When it is not, we need to convert the corp type to a valid entity type before posting it to namex. This should also fix Verify - Unable to pay for Extra provincial registrations entity#17780 and Verify - Unable to File and Pay for the Change of Name NR for the societies. entity#17791.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).