Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSADT1-1120: Add DOB for Individuals #740

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

mamartinezmejia
Copy link
Collaborator

@mamartinezmejia mamartinezmejia commented Jan 16, 2024


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed for 'forest-client-frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Frontend unit Test Coverage

Coverage after merging fix/FSADT1-1120 into main will be
56.92%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue50%50%0%70%108, 36, 39–40, 44, 52–53, 61–62
   directivesMap.ts100%100%100%100%
src/components
   DataFetcher.vue85%60%83.33%95.83%33–35, 50, 55
   MainHeaderComponent.vue81.48%78.57%70%87.27%105, 112, 116, 127, 129, 139, 141, 152, 178, 181, 190, 206, 222, 222, 222, 235, 246, 257, 44, 53–54, 58
   UserProfileComponent.vue80%33.33%100%85.71%17, 17, 19, 23
src/components/forms
   AutoCompleteInputComponent.vue75.56%58.14%80.95%84.51%111–112, 128, 133–134, 179, 208, 47, 60, 62, 62, 62, 62, 62–64, 66, 66, 66–68, 78, 81, 81, 81, 81, 81, 83, 85
   DropdownInputComponent.vue90.20%87.10%83.33%94.34%111, 136, 67, 81, 81, 81–82
   MultiselectInputComponent.vue92.63%91.67%85.71%96%100, 109, 80, 89
   RadioInputComponent.vue87.72%85.71%75%93.55%39, 44, 80, 89
   ReadOnlyComponent.vue66.67%100%100%66.67%2
   TextInputComponent.vue85.71%75%84.62%92.50%1, 105, 123, 129, 137, 62, 91, 96–97
src/components/forms/DateInputComponent
   DateInputPart.vue91.67%75%100%100%46, 50
   common.ts100%100%100%100%
   index.vue81.16%74.73%75%86.27%1, 1, 137, 172–174, 182–185, 185, 185–186, 213, 215, 218–219, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 319–320, 330–333, 340, 352, 381, 384, 432, 450, 460, 467
src/components/grouping
   AddressGroupComponent.vue1.23%0%0%2.68%1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 105–106, 108, 108, 108, 112–113, 115–116, 116, 116, 116, 118, 125, 132, 141–142, 142, 142, 142, 144, 146, 148, 152, 154–155, 155, 155–156, 156, 156, 156, 158, 160, 162, 165, 169–170, 170, 170, 172, 174, 178–179, 179, 179, 179, 181, 183, 185, 189–190, 190, 190, 193, 195–196, 196–197, 197, 199, 20, 202, 204–206, 206, 206, 206, 206–208, 216, 218–219, 222, 224, 229–230, 230, 230–235, 235, 235–237, 240, 253, 260, 260, 260–261, 261, 261–262, 262, 266, 270, 278–279, 279, 285, 285, 285, 287, 287, 287–288, 288, 288, 29, 290, 290, 298, 306, 306, 306–307, 307, 307, 311, 328, 328, 328–329, 329, 329, 343, 343, 343, 345, 345, 345, 35, 357, 36, 360, 360, 360–361, 361, 361, 365, 365, 367, 367, 367, 38, 41, 43, 43, 43, 47, 47, 47, 50–52, 54–55, 58, 62–64, 67–69, 73, 77, 77, 77, 77, 77, 77–78, 83, 85, 88–89, 89, 89, 89, 89–90, 93, 96
   ContactGroupComponent.vue69.80%85.45%48.15%65.67%106–107, 130, 155, 164, 171, 180, 187, 195, 205, 213, 227, 233, 238, 244, 268, 42, 55–56, 83, 83, 83–84, 90, 90, 90–91, 95, 95, 95–96
   ErrorNotificationGroupingComponent.vue78.38%66.67%66.67%91.43%110, 117, 117, 117, 121, 129, 129, 138, 150, 58, 63, 81, 90, 98
src/composables
   useElementVisibility.ts96.55%87.50%100%100%6
   useFetch.ts90.77%73.68%100%97.56%117, 121, 130, 17, 51, 88
   useFocus.ts37.04%19.23%50%44.19%114, 120, 120, 120, 120, 120–121, 124, 128–130, 130, 130–131, 133, 142, 145, 148, 34, 36–38, 50, 55, 57, 60, 63, 63, 63, 65–67, 67, 67, 69, 71, 77, 77, 77, 80–81, 84, 99, 99, 99
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/helpers
   CustomDirectives.ts92.86%82.61%100%100%19, 36, 43, 45
   DataConversors.ts75.61%79.17%50%73.33%33, 38, 38, 38, 38, 38–39, 4, 41
   

Copy link

Frontend component Test Coverage

Coverage after merging fix/FSADT1-1120 into main will be
69.61%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue100%100%100%100%
   CoreConstants.ts100%100%100%100%
   directivesMap.ts100%100%100%100%
   main.ts100%100%100%100%
   routes.ts100%100%100%100%
   shims-vue.d.ts100%100%100%100%
src/components
   DataFetcher.vue97.14%80%100%100%33
   MainHeaderComponent.vue100%100%100%100%
   UserProfileComponent.vue100%100%100%100%
   types.ts100%100%100%100%
src/components/forms
   AutoCompleteInputComponent.vue93.02%91.89%85.71%95.77%179, 208, 47, 68, 81, 83
   DropdownInputComponent.vue91.75%92.31%83.33%94.34%111, 136, 81, 81–82
   MultiselectInputComponent.vue92.39%90.48%85.71%96%100, 109, 47, 89
   RadioInputComponent.vue89.09%75%83.33%96.77%39, 49, 80, 91
   ReadOnlyComponent.vue100%100%100%100%
   TextInputComponent.vue89.19%80.95%84.62%95%1, 105, 123, 129, 137, 62
src/components/forms/DateInputComponent
   DateInputPart.vue12.50%0%0%21.43%16, 21, 23, 25, 27, 31, 37, 39, 46, 46, 50, 50, 57, 57, 57–58, 58, 58, 8
   common.ts100%100%100%100%
   index.vue3.11%0%0%5.23%1, 1, 1, 1, 101, 101–103, 106, 106–108, 108, 108, 114, 114, 114, 114–115, 117, 120, 120, 122, 128, 128, 128, 128–129, 132, 135–137, 140, 146, 148–149, 149, 149, 152, 154–156, 158, 160–161, 161, 161, 161, 163–164, 164, 164, 164, 167, 169, 171–174, 177–182, 182, 182, 182–185, 185–186, 189, 193–194, 198–201, 203, 203–204, 207–208, 212–213, 213, 215, 215, 215–216, 218, 218–219, 222–223, 225, 228, 234, 240, 246, 269, 269, 269, 269–270, 272–273, 280, 280–281, 283–285, 296, 296, 296–297, 297, 297–298, 298, 298, 30, 300, 300–301, 304–307, 309, 311, 311–312, 312, 312, 312, 316, 319, 319–320, 322, 325–327, 329–333, 336–337, 340, 340–342, 344–345, 347–348, 350, 352, 352–353, 358, 363, 365, 371, 373–379, 379–381, 381–384, 384–385, 391–393, 395, 432, 432, 439, 439–440, 440, 440, 449, 449–450, 450, 450, 459, 459–460, 460, 460, 467, 467, 54, 76, 76, 76, 78, 80, 86, 92
src/components/grouping
   AddressGroupComponent.vue90.79%89.89%97.37%89.29%116, 132, 142, 148, 155–156, 156, 156, 156, 158, 160, 162, 179, 185, 196, 218–219, 235, 266, 311, 367
   ContactGroupComponent.vue91.78%96.15%88.89%89.55%227, 233, 255, 268, 84, 91, 95, 95–96
   ErrorNotificationGroupingComponent.vue100%100%100%100%
src/composables
   useElementVisibility.ts100%100%100%100%
   useFetch.ts100%100%100%100%
   useFocus.ts100%100%100%100%
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/dto
   ApplyClientNumberDto.ts100%100%100%100%
   CommonTypesDto.ts100%100%100%100%
src/helpers
   CustomDirectives.ts100%100%100%100%
   DataConversors.ts100%100%100%100%
   ForestClientUserSession.ts100%100%100%100%
src/helpers/validators
   BCeIDFormValidations.ts100%100%100%100%
   GlobalValidators.ts100%100%100%100%
   SubmissionValidators.ts100%100%100%100%
src/pages
   ErrorPage.vue100%100%100%100%
   FormBCSCPage.vue100%100%100%100%
   FormBCeIDPage.vue100%100%100%100%
   FormSubmittedPage.vue100%100%100%100%
   LandingPage.vue100%100%100%100%
   NotFoundPage.vue100%100%100%100%
   SubmissionListPage.vue100%100%100%100%
   SubmissionReviewPage.vue100%100%100%100%
   UserLoadingPage.vue100%100%100%100%
src/pages/bceidform
   AddressWizardStep.vue100%100%100%100%
   BusinessInformationWizardStep.vue70.92%68.93%75%71.77%1, 1, 1, 1, 104–106, 167–169, 184, 184–188, 191, 202, 202–204, 208, 211–212, 212–214, 216, 222–223, 225–227, 227, 227, 231–233, 242, 242, 242–243, 246, 249, 270, 277, 337, 347, 369, 414, 418, 424, 424, 424, 438, 442, 442, 442–443, 443, 443, 49, 71, 75, 83, 83, 89
   ContactWizardStep.vue59.26%64%47.83%61.67%118, 118, 118, 123, 143, 150, 154, 171, 173, 40, 40–41, 41, 41, 43–45, 48, 54–55, 64, 72–73, 76, 76–78, 80, 84–87
   ReviewWizardStep.vue100%100%100%100%
src/services
   ForestClientService.ts100%100%100%100%

Copy link

Frontend e2e Test Coverage

Coverage after merging fix/FSADT1-1120 into main will be
82.63%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue85.29%83.33%50%100%62
   CoreConstants.ts100%100%100%100%
   directivesMap.ts100%100%100%100%
   main.ts100%100%100%100%
   routes.ts100%100%100%100%
   shims-vue.d.ts100%100%100%100%
src/components
   DataFetcher.vue97.14%80%100%100%33
   MainHeaderComponent.vue64.89%77.27%10%60%139, 178–181, 190, 202, 202, 202, 222, 235, 246, 257, 44, 44–45, 53, 53, 53, 53–54, 56–58, 58–59, 59, 59–60, 62, 75, 84, 90, 90, 90–91, 93
   UserProfileComponent.vue80%33.33%100%85.71%17, 17, 19, 23
   types.ts100%100%100%100%
src/components/forms
   AutoCompleteInputComponent.vue93.02%91.89%85.71%95.77%179, 208, 47, 68, 81, 83
   DropdownInputComponent.vue96.91%96.15%94.44%98.11%111, 136
   MultiselectInputComponent.vue92.39%90.48%85.71%96%100, 109, 47, 89
   RadioInputComponent.vue89.09%75%83.33%96.77%39, 49, 80, 91
   ReadOnlyComponent.vue100%100%100%100%
   TextInputComponent.vue91.89%80.95%92.31%97.50%1, 123, 129, 137, 62
src/components/forms/DateInputComponent
   DateInputPart.vue91.67%75%100%100%46, 50
   common.ts100%100%100%100%
   index.vue83.66%73.61%93.75%86.27%1, 1, 108, 117, 120, 122, 137, 149, 203, 218, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 330–333, 340–342, 344–345, 347–348, 350, 352, 352–353, 432, 467
src/components/grouping
   AddressGroupComponent.vue90.79%89.89%97.37%89.29%116, 132, 142, 148, 155–156, 156, 156, 156, 158, 160, 162, 179, 185, 196, 218–219, 235, 266, 311, 367
   ContactGroupComponent.vue97.26%100%96.30%95.52%268, 84, 91
   ErrorNotificationGroupingComponent.vue42.86%17.24%66.67%60%110, 110, 117, 117, 117, 121, 121, 129, 129, 138, 138, 150, 150, 163, 30–31, 31, 34, 58–59, 59, 63, 63–64, 64, 64, 66–67, 67, 69, 73–74, 74, 76, 90, 95, 98, 98
src/composables
   useElementVisibility.ts100%100%100%100%
   useFetch.ts100%100%100%100%
   useFocus.ts100%100%100%100%
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/dto
   ApplyClientNumberDto.ts100%100%100%100%
   CommonTypesDto.ts100%100%100%100%
src/helpers
   CustomDirectives.ts100%100%100%100%
   DataConversors.ts100%100%100%100%
   ForestClientUserSession.ts100%100%100%100%
src/helpers/validators
   BCeIDFormValidations.ts100%100%100%100%
   GlobalValidators.ts100%100%100%100%
   SubmissionValidators.ts100%100%100%100%
src/pages
   ErrorPage.vue25%100%100%25%11–12, 2
   FormBCSCPage.vue82.83%66.10%74.19%91.61%1, 121–122, 135, 209, 270, 272, 281, 296–298, 306, 311, 323, 323, 323, 325–326, 331, 377, 463, 470, 477, 50, 508, 51–52, 544, 544, 544, 63, 80
   FormBCeIDPage.vue58.37%52.13%36.67%67.67%1, 1, 1, 1, 1, 110–112, 118, 118–119, 124, 124, 124, 127–128, 133, 239, 241, 250, 260–261, 261, 261, 261, 261, 261–264, 270, 276, 281, 281–286, 300, 300–301, 306, 306–307, 307–308, 308, 313, 319–320, 322, 322–324, 329–331, 341, 344–348, 358, 358, 360–362, 447, 454, 469, 477, 489, 498, 537, 540, 540, 540, 559, 68–70, 89, 93–94, 96, 99
   FormSubmittedPage.vue61.11%25%0%83.33%12, 30, 32, 32, 32
   LandingPage.vue76.19%42.86%100%92.86%18, 18–19, 48, 58
   SubmissionListPage.vue93.26%77.78%100%96.43%153, 42–43, 46, 82, 85
   SubmissionReviewPage.vue74.35%73.12%63.64%78.79%106–107, 107–109, 116, 116, 116, 116–118, 121, 126–128, 137, 137–138, 138, 143–144, 144–147, 151, 151, 165, 189, 193, 198–199, 199, 199, 204, 210, 268, 271, 277, 369, 479, 516, 520–521, 533, 554, 567, 585, 592, 609, 97–99
   UserLoadingPage.vue14.29%0%100%20%12, 14, 14, 14–15, 17
src/pages/bceidform
   AddressWizardStep.vue50.94%57.14%39.13%53.23%107–111, 122, 122, 122, 125, 141, 145, 149, 163–165, 178, 37, 37–38, 38, 38, 40–42, 46, 46–50, 52, 52–53, 58, 76–79
   BusinessInformationWizardStep.vue83.67%83.50%91.67%82.26%1, 1, 104–105, 167–169, 184, 184–188, 191, 212, 222–223, 225–227, 227, 227, 231–233, 242, 246, 249, 270, 277, 337, 347, 369, 414, 418, 49, 71, 75, 89
   ContactWizardStep.vue59.26%64%47.83%61.67%118, 118, 118, 123, 143, 150, 154, 171, 173,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants