TNO-1848: State bug with home filters #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdtoombs
added
bug
jdtoombs
commented
Oct 17, 2023
| @@ -29,7 +29,7 @@ export const ActionSection: React.FC<IActionSectionProps> = ({ values }) => { | |||
| <Row gap="0.5rem" alignItems="center" justifyContent="center"> | |||
| <ContentActions | |||
| init | |||
| filter={(a) => a.id !== +alertId && a.contentTypes.includes(values.contentType)} | |||
| filter={(a) => a.id !== +alertId && a.contentTypes?.includes(values.contentType)} | |||
There was a problem hiding this comment.
This was causing an error for me on the editor side when creating a new snippet
Fosol
requested changes
Oct 18, 2023
| const getClassName = (type: HomeFilterType) => (type === active ? 'active' : 'inactive'); | ||
|
|
||
| useEffect(() => { | ||
| switch (filter.contentTypes[0]) { |
There was a problem hiding this comment.
Will this array ever be empty?
There was a problem hiding this comment.
Actually addressing this right now for another ticket (adding the all option) going to push to this branch with updates when complete
There was a problem hiding this comment.
Updated, additional small ticket added to this PR as well.
| setActive(HomeFilterType.RadioTV); | ||
| break; | ||
| case ContentTypeName.Story: | ||
| console.log(filter); |
Fosol
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the component, and fix state errors so the filter is persisted when navigating back to the list view.
Added ALL toggle: