Date Filter for Subscriber Home #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdtoombs
added
enhancement
|
Also noticing the build errors are not displaying on the browser... going to look into that. |
Fosol
requested changes
Apr 17, 2023
| } | ||
|
|
||
| /** Custom datefilter for the subscriber home page. Control the calendar state with custom button, custom styling also applied. Also allows user to navigate a day at a time via arrow buttons. */ | ||
| export const DateFilter: React.FC<IDateFilterProps> = ({ fetch }) => { |
There was a problem hiding this comment.
I may be blind but I don't see you using this property in the component? Remove it if you aren't.
There was a problem hiding this comment.
Not blind, you are correct
app/subscriber/src/features/content/list-view/interfaces/IContentListFilter.ts
Show resolved
Hide resolved
| @@ -24,6 +25,7 @@ export interface IHomeFilterProps { | |||
| */ | |||
| export const HomeFilters: React.FC<IHomeFilterProps> = ({ fetch }) => { | |||
There was a problem hiding this comment.
It does not appear that you are using this property in this component either. Please remove.
jdtoombs
force-pushed
the
subscriber-filters
branch
from
b0e9392
to
4e37dec
Compare
jdtoombs
commented
Apr 17, 2023
| @@ -9,6 +9,7 @@ | |||
| user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/ | |||
| --> | |||
| <link rel="manifest" href="%PUBLIC_URL%/manifest.json" /> | |||
| <link rel="icon" type="image/x-icon" href="%PUBLIC_URL%/favicon.ico"> | |||
There was a problem hiding this comment.
Seems like manifest.json only works for local..
Fosol
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: