Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View A/V #679

Merged
merged 4 commits into from
Apr 21, 2023
Merged

View A/V #679

merged 4 commits into from
Apr 21, 2023

Conversation

jdtoombs
Copy link
Collaborator

In this PR:

  • can now view images or video on the view content section

@jdtoombs jdtoombs added enhancement New feature or request subscriber PR contains changes towards the subscriber application, labels Apr 20, 2023
@jdtoombs jdtoombs self-assigned this Apr 20, 2023
@jdtoombs jdtoombs requested a review from Fosol as a code owner April 20, 2023 22:32
Fosol
Fosol approved these changes Apr 21, 2023
View reviewed changes
app/subscriber/src/features/content/view-content/ViewContent.tsx Outdated
</Show>
<Show visible={!!avStream && content?.contentType === ContentTypeName.Image}>
<Row justifyContent="center">
<img alt="media-image" src={!!avStream?.url ? avStream?.url : ''} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this warning will keep showing up if you don't resolve it.

@Fosol Fosol merged commit 19ccc3a into dev Apr 21, 2023
@Fosol Fosol deleted the show-av branch April 21, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fosol Fosol Fosol approved these changes

Assignees

@jdtoombs jdtoombs

Labels
enhancement New feature or request subscriber PR contains changes towards the subscriber application,
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdtoombs @Fosol