Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point exception on armhf and i386 #384

Closed
3 tasks
tillea opened this issue Dec 3, 2021 · 7 comments
Closed
3 tasks

Floating point exception on armhf and i386 #384

tillea opened this issue Dec 3, 2021 · 7 comments

Comments

@tillea
Copy link

tillea commented Dec 3, 2021

Please report

  • 2.3.3 Debian packaged
  • Architecture: i386 and armhf
  • There is a bug report from the Debian CI team covering only these two architectures.

Assembly error

The bug report links to the full build log where you dan find at the end:

abyss-rresolver-short  -b1G -j2 -k25  \
-h test-1-rr --dot -c test-1-rr.fa -g test-1-rr.dot test-1.fa test-1.dot test-data/reads1.fastq test-data/reads2.fastq 
make: *** [/usr/bin/abyss-pe:585: test-1-rr.dot] Floating point exception

Question

Does it make sense to run abyss on the said architectures at all? While it is probably interesting to know that there is a potential issue it would probably be a solution to declare the program 64 bit only and we (the Debian Med team who is maintaining the package) can restrict the list of architectures to exclude 32 bit architectures.

Kind regards, Andreas.

@jwcodee
Copy link
Member

jwcodee commented Dec 8, 2021

Hi Andreas, as of this moment we are still supporting the 32-bit arch. Our CI include 32-bit compilation tests and the builds do pass them. We will try to fix the error that you see as soon as possible.

@tillea
Copy link
Author

tillea commented Dec 9, 2021 via email

@vlad0x00
Copy link
Member

vlad0x00 commented Dec 20, 2021

I am not sure it makes sense for us to keep supporting 32 bit. I would never recommend anybody to run ABySS on a 32 bit machine and we can't guarantee that it would run as expected as we don't test whether things work well on such platforms (other than that ABySS compiles). @jowong4 Do you think it makes sense for us to keep supporting it?

@tillea
Copy link
Author

tillea commented Dec 20, 2021 via email

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your interest in ABySS!

@github-actions github-actions bot added the stale label Jan 11, 2022
@tillea
Copy link
Author

tillea commented Jan 11, 2022 via email

@github-actions github-actions bot removed the stale label Jan 12, 2022
@jwcodee
Copy link
Member

jwcodee commented Jan 12, 2022

Hi Andreas, we've discussed as team and decided we will no longer support 32-bit ABySS going forward. While we do try to ensure the binaries compile, we cannot test the quality of assemblies they generate so it doesn't make sense for us to support them. If users want to download 32-bit ABySS, they can do so by downloading older versions of ABySS.

@jwcodee jwcodee closed this as completed Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants