-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.2.5 #348
Release 2.2.5 #348
Conversation
* Added RResolver | ||
|
||
abyss-rresolver-short: | ||
* Improves genome assemblies at unitig stage by using a sliding window at read size level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to say this? Just thinking that someone might infer that their assemblies will be improved but it isn't actually in the pipeline?
Not sure what @schutzekatze thinks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @lcoombe. I would just rephrase it to "Added optional RResolver code" or something like that, to indicate it's not a regularly executed algorithm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can also explicitly just say "currently not part of the main pipeline".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree with @schutzekatze - I think good to be clear that it isn't currently part of the main abyss-pe
driver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the newest update clear enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that looks good to me -- what do you think @schutzekatze ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A p p r o v e d
* Added RResolver | ||
|
||
abyss-rresolver-short: | ||
* Improves genome assemblies at unitig stage by using a sliding window at read size level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A p p r o v e d
This PR contains the version bumps to ABySS and documents modifications found in version 2.2.5