Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paired end mode not working? #36

Closed
aldertzomer opened this issue Nov 5, 2018 · 8 comments
Closed

paired end mode not working? #36

aldertzomer opened this issue Nov 5, 2018 · 8 comments
Assignees
Labels

Comments

@aldertzomer
Copy link

Hi,
I'm trying to use your software as described in the example with paired end fq reads:

biobloomcategorizer --fq -e -p test123 -f "mg1655.bf" 18072D-01-03_S71_L006_R1_001_val_1.fq.gz 18072D-01-03_S71_L006_R2_001_val_2.fq.gz -t 16

However then the program just tells me I'm doing something wrong. Without -e option it works, however then I get the matching/non-matching reads in one file, non-interleaved, which is not what I want. I assume paired end information is not used. Is there a bug somewhere that keeps biobloomcategorizer from recognizing 2 files as paired end reads when using the -e option?

@JustinChu
Copy link
Collaborator

JustinChu commented Nov 7, 2018

Sounds like it could be a bug. What is the error message you get from the -e option? What happens when you try inputting 1 file with the -e option? If it is working correctly it should output an error message in that case, but not when 2 files are listed.

-e should produce 2 files (with a _1.fq and _2.fq suffix) (non-interleaved). You are right about how paired end information is not used when -e is not used.

It could be helpful for me it you show me the --version output as well.

@JustinChu JustinChu self-assigned this Nov 7, 2018
@aldertzomer
Copy link
Author

Error message with option -e:

Input:
biobloomcategorizer --fq -e -p test -f /mnt/data/klif/svermeulen/Scripts_test/BioBloomTools/database/test_db.bf S70_R1.fastq.gz S70_R2.fastq.gz

Output:
Usage of paired end mode:
BioBloomCategorizer [OPTION]... -f "[FILTER1]..." [FILEPAIR1] [FILEPAIR2]
or BioBloomCategorizer [OPTION]... -f "[FILTER1]..." [SMARTPAIR]

No error message with option -e and 1 file

biobloomcategorizer --fq -e -p test -f /mnt/data/klif/svermeulen/Scripts_test/BioBloomTools/database/test_db.bf S70_R1.fastq.gz

Output:
Starting to Load Filters.
Loaded Filter: test_db
Filter Loading Complete.
Filtering Start
File written to: test_test_db_1.
File written to: test_test_db_2.
File written to: test_noMatch_1.
File written to: test_noMatch_2.
File written to: test_multiMatch_1.
File written to: test_multiMatch_2.
Total Reads:121994
Writing file: test_summary.tsv

--version output:
biobloomcategorizer (BIOBLOOMTOOLS) 2.1.2-2-g0703

@aldertzomer
Copy link
Author

To add, it works with interleaved files (although the reverse read of the pair gets placed in the forward (_1) file and the forward read gets placed in the reverse (_2) file

@JustinChu JustinChu added the bug label Nov 8, 2018
@JustinChu
Copy link
Collaborator

Thanks for the report. I've found the bug and it will be fixed soon.
The smart pairing option is assigning the (_1) and (_2) arititrarally based on which it sees first. I agree that the order should be changed though and I will change that as well.

@JustinChu
Copy link
Collaborator

The bug should be fixed in the lastest version of the master branch 8a47ccb.

Sorry for the problem, turns out the new smart pairing code was the cause of the issue. When only one file is listed there should indeed be no error.

Thanks again.

@aldertzomer
Copy link
Author

It works pefectly! Thank you very much. We can now screen our metagenomics for contaminating ( in our case non-human) host DNA in minutes.

@JustinChu
Copy link
Collaborator

Great I'll make sure the fix is present in the release version of 2.1.2.

@JustinChu
Copy link
Collaborator

Sorry I didn't realize this until now but the files should have extensions on them for .fq or .fa.

I've pushed a fix for this on the main branch. Minor issue, the output should still have been .fq by default if you used the output options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants