Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v3.14.0 #44

Merged
merged 24 commits into from
Jun 30, 2022
Merged

Release/v3.14.0 #44

merged 24 commits into from
Jun 30, 2022

Conversation

mathieulemieux
Copy link
Member

Improvements

  • Update to parser v3.16
  • Update to schema v4
  • Add variant parser pkg version to version endpoint

Bug Fixes

  • Remove superfluous check in query_builder
  • link immediate children instead of descendants
  • Remove leftover exports that are no longer valid
  • Change default graphkb_admin user for pori_admin

@mathieulemieux mathieulemieux added the release Release PR. Should contain the version increment and putative release notes as the description label Jun 23, 2022
@mathieulemieux mathieulemieux self-assigned this Jun 23, 2022
@mathieulemieux
Copy link
Member Author

Tested with ipr client and graphkb client on containerdev01 with local graphkb_api build and ipr_db build.
Tested with Postman, graphkb loader and graphkb client on phage server.

@mathieulemieux
Copy link
Member Author

This PR replace both #40 and #41, and incorporate changes to the develop branch since.

@@ -5,7 +5,7 @@
This repository is part of the [platform for oncogenomic reporting and interpretation](https://github.com/bcgsc/pori).

The GraphKB database is implemented using [orientDB](https://github.com/orientechnologies/orientdb) and [orientjs](https://github.com/orientechnologies/orientjs).
It is a graph database which is used to store variants, ontologies, and the relevance of this terms and variants. The KB uses strict controlled vocabulary to provide a parseable and machine-readable interface for other applications to build on. The API is a REST API built on node/express.
It is a graph database which is used to store variants, ontologies, and the relevance of this terms and variants. The KB uses strict controlled vocabulary to provide a parsable and machine-readable interface for other applications to build on. The API is a REST API built on node/express.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something is wrong with this first sentence - this -> these possibly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to translate this sentence in my head and make sense of it. What about this? :

"It is a graph database which is used to store variants, ontologies, and statements about the relevance of these variants in a specific disease context. The knowledge base uses strict controlled vocabulary to provide a parsable and machine-readable interface for other applications to build on. The API is a REST API built on node/express."

@github-actions
Copy link

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit df73e1f. ± Comparison against base commit ac73cfe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release PR. Should contain the version increment and putative release notes as the description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants