Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/KBDEV-1194 get updated studies for last two weeks in clinicaltrials #143

Conversation

sshugsc
Copy link
Contributor

@sshugsc sshugsc commented Mar 28, 2024

KBDEV-1194

  • update clinicaltrialsgov to load last updated data
  • add maxRecords options to clinicaltrialsgov
  • remove the out-of-dated rss/xml related code

@sshugsc sshugsc self-assigned this Mar 28, 2024

This comment has been minimized.

src/clinicaltrialsgov/README.md Outdated Show resolved Hide resolved
src/clinicaltrialsgov/README.md Outdated Show resolved Hide resolved
bin/load.js Show resolved Hide resolved
bin/load.js Show resolved Hide resolved
bin/load.js Outdated Show resolved Hide resolved
bin/load.js Show resolved Hide resolved
src/clinicaltrialsgov/index.js Outdated Show resolved Hide resolved
src/clinicaltrialsgov/index.js Show resolved Hide resolved
src/clinicaltrialsgov/index.js Outdated Show resolved Hide resolved
src/clinicaltrialsgov/index.js Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@mathieulemieux
Copy link
Member

@sshugsc, to be safe, testing with some other loaders via the CLI would be a must before merging.

@sshugsc sshugsc merged commit 200296e into develop Apr 4, 2024
5 checks passed

This comment has been minimized.

1 similar comment
Copy link

github-actions bot commented Apr 4, 2024

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 200296e. ± Comparison against base commit d1c3f6e.

@mathieulemieux
Copy link
Member

@sshu, can you post here which loaders you tested (the command you used) so we may want to use the same ones for testing the CLI from now on? I'm curious; have you choose one file loader, one api, cosmic and civic, in conjunction with the maxRecords flag?

@sshugsc
Copy link
Contributor Author

sshugsc commented Apr 5, 2024

@sshu, can you post here which loaders you tested (the command you used) so we may want to use the same ones for testing the CLI from now on? I'm curious; have you choose one file loader, one api, cosmic and civic, in conjunction with the maxRecords flag?

I tested file loaders(ncit, refseq), api loaders(oncotree, docm), cosmic (resistance) and civic. They all work fine.

@mathieulemieux
Copy link
Member

oh, that's a lot! Not the whole datasets I suppose; have you used the maxRecords flag?

@sshugsc
Copy link
Contributor Author

sshugsc commented Apr 6, 2024

oh, that's a lot! Not the whole datasets I suppose; have you used the maxRecords flag?

yeah, tried maxRecords flag for them. Work good on most of them, but oncotree didn't support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants