Feature/gero 296 tmbur high matches #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinbleile
requested review from
darenillas,
mathieulemieux,
creisle,
mattdoug604 and
elewis2
elewis2
reviewed
May 17, 2023
| @@ -337,7 +337,7 @@ def annotate_positional_variants( | |||
| matches = gkb_match.match_positional_variant(graphkb_conn, variant) | |||
| except HTTPError: | |||
There was a problem hiding this comment.
would be safer to check if this error is actually the devsu-1885 error, and rethrow if not
There was a problem hiding this comment.
Hi @elewis2
That does make more sense - I just added it to the other PR though - closing this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates